Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(module:tooltip,*): remove deprecated API #5502

Merged
merged 9 commits into from
Sep 22, 2020

Conversation

wzhudev
Copy link
Member

@wzhudev wzhudev commented Jul 2, 2020

BREAKING-CHANGE: remove API without specific prefix

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[x] Other... Please describe: remove deprecated API

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[ ] No

Other information

@zorro-bot
Copy link

zorro-bot bot commented Jul 2, 2020

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented Jul 2, 2020

Codecov Report

Merging #5502 into master will increase coverage by 0.07%.
The diff coverage is 90.47%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5502      +/-   ##
==========================================
+ Coverage   90.27%   90.34%   +0.07%     
==========================================
  Files         456      456              
  Lines       13747    13726      -21     
  Branches     2164     2150      -14     
==========================================
- Hits        12410    12401       -9     
+ Misses        821      814       -7     
+ Partials      516      511       -5     
Impacted Files Coverage Δ
components/tooltip/base.ts 94.08% <86.66%> (+1.57%) ⬆️
components/popconfirm/popconfirm.ts 100.00% <100.00%> (ø)
components/popover/popover.ts 92.85% <100.00%> (+1.19%) ⬆️
components/tooltip/tooltip.ts 100.00% <100.00%> (ø)
components/table/src/table-style.service.ts 94.82% <0.00%> (-1.73%) ⬇️
components/date-picker/date-picker.component.ts 94.81% <0.00%> (-0.78%) ⬇️
...mponents/date-picker/date-range-popup.component.ts 91.07% <0.00%> (+1.07%) ⬆️
components/core/util/text-measure.ts 91.30% <0.00%> (+1.73%) ⬆️
components/table/src/table/tr-measure.component.ts 100.00% <0.00%> (+13.63%) ⬆️
components/table/src/table/tbody.component.ts 100.00% <0.00%> (+14.28%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b909354...198ab6e. Read the comment docs.

@wzhudev wzhudev marked this pull request as draft July 7, 2020 16:23
@wzhudev
Copy link
Member Author

wzhudev commented Jul 7, 2020

I will rework this PR after merging other PRs that related. I am hanging this for now.

We can not continue.

@wzhudev wzhudev marked this pull request as ready for review September 19, 2020 05:38
@hsuanxyz hsuanxyz merged commit 451a569 into NG-ZORRO:master Sep 22, 2020
@github-actions
Copy link

github-actions bot commented Sep 22, 2020

😭 Deploy PR Preview 451a569 failed. Build logs

🤖 By surge-preview

@wzhudev wzhudev deleted the tooltip-refactor-v10 branch September 23, 2020 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants