-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(module: tree): fix nzBlockNode not work #5507
Conversation
This preview will be available after the AzureCI is passed. |
|
Codecov Report
@@ Coverage Diff @@
## master #5507 +/- ##
==========================================
+ Coverage 91.16% 91.22% +0.06%
==========================================
Files 453 454 +1
Lines 13902 13953 +51
Branches 2211 2219 +8
==========================================
+ Hits 12674 12729 +55
+ Misses 728 719 -9
- Partials 500 505 +5
Continue to review full report at Codecov.
|
Thanks for your PR, |
ok, if this is true, i'll add test later |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You just need to change [class.ant-tree-list-holder-inner]="nzSelectMode"
to [class.ant-tree-list-holder-inner]="!nzSelectMode"
[class.ant-select-tree-list-holder-inner]="nzSelectMode" | ||
[class.ant-tree-list-holder-inner]="nzSelectMode" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only needs to change [class.ant-tree-list-holder-inner]="nzSelectMode"
to [class.ant-tree-list-holder-inner]="!nzSelectMode"
, the className of blocknode follows .ant-tree.ant-tree-block-node .ant-tree-list-holder-inner .ant-tree-node-content-wrapper
[class.ant-select-tree-list-holder-inner]="nzSelectMode" | ||
[class.ant-tree-list-holder-inner]="nzSelectMode" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same with above
77e3d5a
to
b9b325b
Compare
* fix(module: tree): fix nzBlockNode not work * test: add test for nzBlockNode
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information