Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module:modal): change back to FocusTrapFactory #5596

Merged
merged 1 commit into from
Jul 22, 2020
Merged

fix(module:modal): change back to FocusTrapFactory #5596

merged 1 commit into from
Jul 22, 2020

Conversation

rppig42
Copy link
Contributor

@rppig42 rppig42 commented Jul 22, 2020

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

#5591

the new introduced ConfigurableFocusTrapFactory strategy disables clicks outside overlay, which is not compatible with many third-party libraries.

Literally, FocusTrap should only prevent focus event other than click event.

On the other hand, even Angular Material is still using the deprecated FocusTrapFactory for now.

Issue Number: 5591

What is the new behavior?

Change back to FocusTrapFactory, which enables clicks outside overlay.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@rppig42 rppig42 requested a review from hsuanxyz as a code owner July 22, 2020 08:28
@zorro-bot
Copy link

zorro-bot bot commented Jul 22, 2020

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented Jul 22, 2020

Codecov Report

Merging #5596 into master will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5596      +/-   ##
==========================================
+ Coverage   87.70%   87.72%   +0.01%     
==========================================
  Files         458      458              
  Lines       13788    13788              
  Branches     2258     2258              
==========================================
+ Hits        12093    12095       +2     
+ Misses       1205     1204       -1     
+ Partials      490      489       -1     
Impacted Files Coverage Δ
...ponents/modal/modal-confirm-container.component.ts 100.00% <ø> (ø)
components/modal/modal-container.component.ts 100.00% <ø> (ø)
components/drawer/drawer.component.ts 97.82% <100.00%> (ø)
components/modal/modal-container.ts 93.04% <100.00%> (ø)
components/core/util/text-measure.ts 91.30% <0.00%> (+1.73%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b1e1bd2...2a842a9. Read the comment docs.

Copy link
Member

@hsuanxyz hsuanxyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vthinkxie vthinkxie merged commit 9805620 into NG-ZORRO:master Jul 22, 2020
hsuanxyz pushed a commit to hsuanxyz/ng-zorro-antd that referenced this pull request Aug 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants