Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module:tabs): not emit click event from dropdown menu #5639

Merged
merged 1 commit into from
Aug 3, 2020

Conversation

hsuanxyz
Copy link
Member

@hsuanxyz hsuanxyz commented Aug 3, 2020

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@hsuanxyz hsuanxyz requested a review from NearZXH as a code owner August 3, 2020 02:14
@zorro-bot
Copy link

zorro-bot bot commented Aug 3, 2020

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented Aug 3, 2020

Codecov Report

Merging #5639 into master will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5639      +/-   ##
==========================================
+ Coverage   90.29%   90.30%   +0.01%     
==========================================
  Files         455      455              
  Lines       13786    13787       +1     
  Branches     2258     2258              
==========================================
+ Hits        12448    12451       +3     
+ Misses        820      819       -1     
+ Partials      518      517       -1     
Impacted Files Coverage Δ
components/tabs/tabset.component.ts 96.40% <ø> (ø)
components/tabs/tab-nav-operation.component.ts 62.06% <100.00%> (+1.35%) ⬆️
components/core/util/text-measure.ts 91.30% <0.00%> (+1.73%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2ede777...e5bc300. Read the comment docs.

Copy link
Member

@vthinkxie vthinkxie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@vthinkxie vthinkxie merged commit 201ef52 into NG-ZORRO:master Aug 3, 2020
hsuanxyz added a commit to hsuanxyz/ng-zorro-antd that referenced this pull request Aug 5, 2020
@hsuanxyz hsuanxyz deleted the fix/tabs-op-click branch August 5, 2020 02:24
@hsuanxyz hsuanxyz restored the fix/tabs-op-click branch August 5, 2020 02:24
@hsuanxyz hsuanxyz deleted the fix/tabs-op-click branch August 5, 2020 02:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants