Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP:fix(module:select): input search not work in IE11 #5652

Closed
wants to merge 1 commit into from

Conversation

wenqi73
Copy link
Member

@wenqi73 wenqi73 commented Aug 6, 2020

Fixes #5645

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@wenqi73 wenqi73 requested a review from vthinkxie as a code owner August 6, 2020 02:39
@zorro-bot
Copy link

zorro-bot bot commented Aug 6, 2020

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented Aug 6, 2020

Codecov Report

Merging #5652 into master will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5652      +/-   ##
==========================================
+ Coverage   90.31%   90.32%   +0.01%     
==========================================
  Files         455      455              
  Lines       13788    13788              
  Branches     2258     2258              
==========================================
+ Hits        12452    12454       +2     
+ Misses        819      817       -2     
  Partials      517      517              
Impacted Files Coverage Δ
components/select/select-search.component.ts 86.95% <100.00%> (ø)
components/tabs/tab-nav-bar.component.ts 85.51% <0.00%> (+0.70%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f5899ad...6484eec. Read the comment docs.

@wenqi73 wenqi73 force-pushed the ie11-select-focus branch from 726de03 to 6484eec Compare August 6, 2020 05:36
@h4rm
Copy link

h4rm commented Aug 6, 2020

hi @wenqi73
I tested your fix locally and I cannot confirm that it fixes the problem on IE11 unfortunately.

@wenqi73
Copy link
Member Author

wenqi73 commented Aug 6, 2020

@h4rm My ie environment's network is terrible, could you help test on ie11?

@wenqi73 wenqi73 changed the title fix(module:select): input search not work in IE11 WIP:fix(module:select): input search not work in IE11 Aug 6, 2020
@pr-triage pr-triage bot removed the PR: unreviewed label Aug 6, 2020
@wenqi73 wenqi73 closed this Aug 6, 2020
@wenqi73 wenqi73 deleted the ie11-select-focus branch October 20, 2020 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

nz-select component input search is not working under ie 11
2 participants