Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module:select): display IME input completely #5657

Conversation

QichenZhu
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: #5656

IME input is not displayed in the select box completely.

What is the new behavior?

IME input is displayed in the select box completely.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

The side effect is that a search is performed every time a key is pressed in IME input mode.

@zorro-bot
Copy link

zorro-bot bot commented Aug 7, 2020

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented Aug 7, 2020

Codecov Report

Merging #5657 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #5657   +/-   ##
=======================================
  Coverage   90.31%   90.31%           
=======================================
  Files         455      455           
  Lines       13788    13788           
  Branches     2258     2181   -77     
=======================================
  Hits        12452    12452           
  Misses        819      819           
  Partials      517      517           
Impacted Files Coverage Δ
components/select/select-search.component.ts 86.95% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f5899ad...e4ac228. Read the comment docs.

@vthinkxie vthinkxie merged commit 111721a into NG-ZORRO:master Sep 24, 2020
@vthinkxie
Copy link
Member

lgtm
thanks @QichenZhu

@github-actions
Copy link

github-actions bot commented Sep 24, 2020

🎊 PR Preview 111721a has been successfully built and deployed to https://NG-ZORRO-ng-zorro-antd-preview-pr-5657.surge.sh

🕐 Build time: 1571.585s

🤖 By surge-preview

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants