Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module:time-picker): add readonly attribute #5679

Closed
wants to merge 1 commit into from

Conversation

wenqi73
Copy link
Member

@wenqi73 wenqi73 commented Aug 14, 2020

Closes #5678
Closes #5741

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@codecov
Copy link

codecov bot commented Aug 14, 2020

Codecov Report

Merging #5679 into master will decrease coverage by 0.06%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5679      +/-   ##
==========================================
- Coverage   90.09%   90.03%   -0.07%     
==========================================
  Files         455      455              
  Lines       13798    13794       -4     
  Branches     2183     2182       -1     
==========================================
- Hits        12431    12419      -12     
- Misses        843      851       +8     
  Partials      524      524              
Impacted Files Coverage Δ
components/time-picker/time-picker.component.ts 90.90% <ø> (-2.57%) ⬇️
components/core/util/text-measure.ts 89.56% <0.00%> (-1.74%) ⬇️
components/tabs/tab-nav-bar.component.ts 80.91% <0.00%> (-1.42%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8415a70...7cff4de. Read the comment docs.

@wenqi73 wenqi73 requested a review from hsuanxyz August 14, 2020 15:53
@wenqi73 wenqi73 closed this Sep 14, 2020
@wenqi73 wenqi73 deleted the tp-not-focus branch September 14, 2020 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant