Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(module:date-picker): will not sort range date #5812

Merged
merged 2 commits into from
Sep 23, 2020

Conversation

wenqi73
Copy link
Member

@wenqi73 wenqi73 commented Sep 18, 2020

Closes #5572
Closes #5651
Closes #5631

  • if one value change, the cursor will always move to the other input although has value.
  • will not sort the range date.
  • when sorting is wrong, reset the other input.

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[x] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[ ] No

Other information

@codecov
Copy link

codecov bot commented Sep 18, 2020

Codecov Report

Merging #5812 into master will decrease coverage by 0.00%.
The diff coverage is 84.48%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5812      +/-   ##
==========================================
- Coverage   90.24%   90.24%   -0.01%     
==========================================
  Files         463      463              
  Lines       13887    13900      +13     
  Branches     2182     2186       +4     
==========================================
+ Hits        12533    12544      +11     
  Misses        833      833              
- Partials      521      523       +2     
Impacted Files Coverage Δ
components/date-picker/picker.component.ts 92.15% <42.85%> (-5.11%) ⬇️
...mponents/date-picker/date-range-popup.component.ts 91.66% <96.15%> (+0.59%) ⬆️
components/core/time/candy-date.ts 92.15% <100.00%> (+2.36%) ⬆️
components/date-picker/date-picker.service.ts 100.00% <100.00%> (ø)
components/tabs/tab-nav-bar.component.ts 82.33% <0.00%> (+0.70%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fc12672...9ada35d. Read the comment docs.

@wenqi73 wenqi73 force-pushed the refactor-range-disabled branch 2 times, most recently from 269f270 to ccdb6ed Compare September 21, 2020 08:51
@wenqi73 wenqi73 requested a review from hsuanxyz September 21, 2020 17:50
@wenqi73 wenqi73 force-pushed the refactor-range-disabled branch 2 times, most recently from 23f0f9d to dcaddd4 Compare September 23, 2020 08:05
@wenqi73 wenqi73 force-pushed the refactor-range-disabled branch from dcaddd4 to 9ada35d Compare September 23, 2020 08:07
@hsuanxyz hsuanxyz merged commit c290ca4 into NG-ZORRO:master Sep 23, 2020
@wenqi73 wenqi73 deleted the refactor-range-disabled branch September 23, 2020 08:51
@github-actions
Copy link

github-actions bot commented Sep 23, 2020

😭 Deploy PR Preview c290ca4 failed. Build logs

🤖 By surge-preview

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants