feat(module: graph): support graph component #6053
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This preview will be available after the AzureCI is passed. |
simplejason
force-pushed
the
nz-graph
branch
from
f09c978 to
8ef8126
Compare
Codecov Report
@@ Coverage Diff @@
## master #6053 +/- ##
==========================================
- Coverage 89.95% 89.83% -0.12%
==========================================
Files 465 465
Lines 14046 14078 +32
Branches 2308 2235 -73
==========================================
+ Hits 12635 12647 +12
- Misses 863 880 +17
- Partials 548 551 +3
Continue to review full report at Codecov.
|
vthinkxie
reviewed
Nov 16, 2020
vthinkxie
reviewed
Nov 16, 2020
vthinkxie
reviewed
Nov 16, 2020
vthinkxie
reviewed
Nov 16, 2020
vthinkxie
reviewed
Nov 16, 2020
vthinkxie
reviewed
Nov 16, 2020
vthinkxie
reviewed
Nov 16, 2020
vthinkxie
reviewed
Nov 16, 2020
vthinkxie
reviewed
Nov 16, 2020
vthinkxie
reviewed
Nov 16, 2020
vthinkxie
reviewed
Nov 16, 2020
simplejason
force-pushed
the
nz-graph
branch
from
cbd1b95 to
86c1d3c
Compare
feat(module: graph): init graph feat(module: graph): fix package.json fix(module: graph): fix some definitions fix(module: graph): extend interfaces fix(module: graph): improve autofit size fix(module: graph): fix padding of sub graph, it still has bug fix(module: graph): change package and demo fix(module: graph): allow toggle node by icon fix(module: graph): fix center position fix(module: graph): add minimap fix(module: graph): use d3-* instead of d3 and improve docs fix(module: graph): remove download function fix(module: graph): fix interface and render bugs fix(module: graph): support arrow element fix(module: graph): rename layout method fix(module: graph): refactor apis and inputs fix(module: graph): support custom node template
simplejason
force-pushed
the
nz-graph
branch
from
2f5ee2d to
06137af
Compare
simplejason
changed the title
hsuanxyz
requested changes
Nov 21, 2020
|
|
||
| export class NzGraphData implements NzGraphBaseSource<NzGraphDataDef, string> { | ||
| _data = new BehaviorSubject<NzGraphDataDef>({} as NzGraphDataDef); | ||
| dataSource!: NzGraphDataDef; |
| this.cdr.detectChanges(); | ||
| }); | ||
| } else { | ||
| throw Error(`A valid data source must be provided.`); |
There was a problem hiding this comment.
既然已经在 ngAfterContentChecked 中检查了，这里为什么还要抛错
| export const NZ_GRAPH_LAYOUT_SETTING: NzLayoutSetting = { | ||
| animation: { | ||
| /** Default duration for graph animations in ms. */ | ||
| duration: 250 |
| const height = contentEle.getBoundingClientRect().height; | ||
| const width = contentEle.getBoundingClientRect().width; | ||
| // Element id type is string | ||
| const targetNode = flattenNodes(renderInfo).find(n => `${n.name}` === nodeEle.id); |
There was a problem hiding this comment.
改成 deepFind， flattenNodes 每次都是全量循环
There was a problem hiding this comment.
部分暂时不改了，下个版本一起做掉，这个rc版本先内部试用
hsuanxyz
approved these changes
Nov 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information