Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(module:date-picker,time-picker): prevent losing input focus #6171

Merged
merged 1 commit into from
Dec 11, 2020

Conversation

wenqi73
Copy link
Member

@wenqi73 wenqi73 commented Dec 9, 2020

close #6170

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[x] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@zorro-bot
Copy link

zorro-bot bot commented Dec 9, 2020

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented Dec 9, 2020

Codecov Report

Merging #6171 (6859ac9) into master (51c4cb2) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6171      +/-   ##
==========================================
- Coverage   89.84%   89.82%   -0.02%     
==========================================
  Files         468      468              
  Lines       14255    14259       +4     
  Branches     2242     2242              
==========================================
+ Hits        12807    12808       +1     
- Misses        892      895       +3     
  Partials      556      556              
Impacted Files Coverage Δ
...mponents/date-picker/date-range-popup.component.ts 90.80% <0.00%> (-1.06%) ⬇️
...ponents/time-picker/time-picker-panel.component.ts 89.02% <0.00%> (-0.73%) ⬇️
components/time-picker/time-holder.ts 94.73% <0.00%> (-1.06%) ⬇️
components/core/util/text-measure.ts 91.30% <0.00%> (+1.73%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 51c4cb2...6859ac9. Read the comment docs.

@hsuanxyz hsuanxyz merged commit a055905 into NG-ZORRO:master Dec 11, 2020
@wenqi73 wenqi73 deleted the dp-prevent branch December 14, 2020 03:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

datepicker, timepicker's input loses focus when clicking panel
2 participants