Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(module:select): support number as label (#6535) #6538

Merged
merged 1 commit into from
Apr 3, 2021
Merged

feat(module:select): support number as label (#6535) #6538

merged 1 commit into from
Apr 3, 2021

Conversation

xiejay97
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: close #6535

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@zorro-bot
Copy link

zorro-bot bot commented Mar 20, 2021

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented Mar 20, 2021

Codecov Report

Merging #6538 (a600581) into master (ddc7ded) will decrease coverage by 0.01%.
The diff coverage is 89.74%.

❗ Current head a600581 differs from pull request most recent head cc79d3d. Consider uploading reports for the commit cc79d3d to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6538      +/-   ##
==========================================
- Coverage   89.90%   89.88%   -0.02%     
==========================================
  Files         479      481       +2     
  Lines       15319    15374      +55     
  Branches     2333     2343      +10     
==========================================
+ Hits        13772    13819      +47     
- Misses        930      937       +7     
- Partials      617      618       +1     
Impacted Files Coverage Δ
components/core/config/config.ts 100.00% <ø> (ø)
components/modal/modal.module.ts 100.00% <ø> (ø)
components/select/select.component.ts 87.09% <57.14%> (-0.49%) ⬇️
components/modal/modal.component.ts 90.32% <62.50%> (-2.62%) ⬇️
components/mention/mention.component.ts 97.72% <75.00%> (+0.01%) ⬆️
components/dropdown/dropdown.directive.ts 88.57% <85.71%> (-0.21%) ⬇️
...ts/auto-complete/autocomplete-trigger.directive.ts 95.83% <100.00%> (+0.15%) ⬆️
components/auto-complete/autocomplete.component.ts 91.58% <100.00%> (+0.24%) ⬆️
components/cascader/cascader.component.ts 94.62% <100.00%> (+0.01%) ⬆️
components/date-picker/date-picker.component.ts 93.46% <100.00%> (+0.04%) ⬆️
... and 19 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ddc7ded...cc79d3d. Read the comment docs.

Copy link
Member

@vthinkxie vthinkxie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@vthinkxie vthinkxie merged commit 1f6ce76 into NG-ZORRO:master Apr 3, 2021
@@ -1223,7 +1223,7 @@ export class TestSelectTemplateDefaultComponent {
nzShowArrow = true;
nzFilterOption: NzFilterOptionType = (searchValue: string, item: NzSelectItemInterface): boolean => {
if (item && item.nzLabel) {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vthinkxie 应该去检查label等于0的情况,需要修复 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

nz-select: use nzOptions cant show label when label is number
2 participants