-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(module:select): support number as label (#6535) #6538
Conversation
This preview will be available after the AzureCI is passed. |
Codecov Report
@@ Coverage Diff @@
## master #6538 +/- ##
==========================================
- Coverage 89.90% 89.88% -0.02%
==========================================
Files 479 481 +2
Lines 15319 15374 +55
Branches 2333 2343 +10
==========================================
+ Hits 13772 13819 +47
- Misses 930 937 +7
- Partials 617 618 +1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
@@ -1223,7 +1223,7 @@ export class TestSelectTemplateDefaultComponent { | |||
nzShowArrow = true; | |||
nzFilterOption: NzFilterOptionType = (searchValue: string, item: NzSelectItemInterface): boolean => { | |||
if (item && item.nzLabel) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@vthinkxie 应该去检查label等于0的情况,需要修复 🙏
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: close #6535
What is the new behavior?
Does this PR introduce a breaking change?
Other information