Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: add inline step for templateUrl #831

Merged
merged 1 commit into from
Dec 30, 2017
Merged

build: add inline step for templateUrl #831

merged 1 commit into from
Dec 30, 2017

Conversation

trotyl
Copy link
Contributor

@trotyl trotyl commented Dec 28, 2017

closes #684

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[x] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[x] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: #684

What is the new behavior?

Enable using templateUrl for components.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

Only made change for button here since it's covered by integration tests. Others can be done in follow ups.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 40.856% when pulling 6400ed1 on trotyl:separate-template into bda29de on NG-ZORRO:master.

@wilsoncook wilsoncook merged commit 1433644 into NG-ZORRO:master Dec 30, 2017
@trotyl trotyl deleted the separate-template branch January 3, 2018 07:08
hsuanxyz pushed a commit to hsuanxyz/ng-zorro-antd that referenced this pull request Aug 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

style: allow separated html file from typescript
3 participants