feat(page: right-control): completed todo item can be hide #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
https://tirelyl.github.io/today-ng-steps online demo |
wzhudev
requested changes
Sep 15, 2018
| 名称 | ||
| <ul nz-menu> | ||
| <li nz-menu-item (click)="toggleCompletedHide()"> | ||
| {{ completedHide ? '显示以完成' : '隐藏已完成' }} |
| <nz-dropdown [nzPlacement]="'bottomRight'"> | ||
| <a nz-dropdown> | ||
| 排序 | ||
| 更多设置 |
wzhudev
reviewed
Sep 15, 2018
| @@ -1,6 +1,6 @@ | |||
| <nz-list *ngIf="todos.length > 0" [nzDataSource]="todos" [nzRenderItem]="item" [nzItemLayout]="'horizontal'"> | |||
| <ng-template #item let-item> | |||
| <nz-list-item class="todo-item" (click)="click(item._id)" (contextmenu)="contextMenu($event, todoContextRef, item._id)"> | |||
| <nz-list-item *ngIf="!(item.completedFlag && completedHide)" class="todo-item" (click)="click(item._id)" (contextmenu)="contextMenu($event, todoContextRef, item._id)"> | |||
There was a problem hiding this comment.
这样的代码把决定该显示什么东西的算法分离到模板当中, 但是更多的算法在组件类里, 分离会造成后续不易维护.
wzhudev
approved these changes
Sep 16, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.