Move elements to finat.ufl rather than ufl.legacy #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 16, 2023
UZerbinati
force-pushed
the
main
branch
24 times, most recently
from
9a46e74 to
4cf5011
Compare
UZerbinati
force-pushed
the
main
branch
12 times, most recently
from
a74307b to
6910a79
Compare
dham
suggested changes
Nov 8, 2023
Co-authored-by: David A. Ham <david.ham@imperial.ac.uk>
|
Hi Matt, sorry if I hadn't look at this PR before, I've been super busy with my transfer thesis. All test are passing, so I'll be merging it now :) |
No worries. I think this PR would've broken Firedrake's main branch until David's correction anyway. Hope the transfer goes well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change will be required following FEniCS/ufl#197 if the approach in FInAT/FInAT#111 is followed.