Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix vulnerable packages + Transient errors in tests #81

Merged
merged 3 commits into from
Mar 11, 2021

Conversation

imnotteixeira
Copy link
Collaborator

I think I finally found a problem that has been killing me for the past months, since tests we failing randomly, which seems to have to do with Promises not being flushed when using mock timers (which was the case in the ApplicationReviewWidget tests)

Some relevant info may be found here:

The solution involved migrating to the new implementation of fake timers from Jest 26 https://jestjs.io/blog/2020/05/05/jest-26#new-fake-timers


Regarding the audit issue, it was a problem with the react-dev-utils package (facebook/create-react-app#10411). Fixed by upgrading its version as well to 11.0.3

@imnotteixeira imnotteixeira self-assigned this Mar 6, 2021
@imnotteixeira imnotteixeira merged commit bebd45a into develop Mar 11, 2021
@imnotteixeira imnotteixeira deleted the fix/audit-issues branch March 11, 2021 00:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants