-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
584-allow uppercase in package name #613
base: main
Are you sure you want to change the base?
Conversation
Type of change is not selected in the description of this PR. |
@@ -10,13 +10,17 @@ | |||
* Make contributing guidelines optional [#465](https://github.com/NLeSC/python-template/pull/465) | |||
* Make developer documentation optional [#467](https://github.com/NLeSC/python-template/pull/541) | |||
* Make Code of Conduct optional [#464](https://github.com/NLeSC/python-template/pull/530) | |||
* CHANGELOG.md is now optional ([#462](https://github.com/NLeSC/python-template/issues/462)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
* CHANGELOG.md is now optional ([#462](https://github.com/NLeSC/python-template/issues/462)) | |
* CHANGELOG.md is now optional [#462](https://github.com/NLeSC/python-template/issues/462) |
@@ -10,13 +10,17 @@ | |||
* Make contributing guidelines optional [#465](https://github.com/NLeSC/python-template/pull/465) | |||
* Make developer documentation optional [#467](https://github.com/NLeSC/python-template/pull/541) | |||
* Make Code of Conduct optional [#464](https://github.com/NLeSC/python-template/pull/530) | |||
* CHANGELOG.md is now optional ([#462](https://github.com/NLeSC/python-template/issues/462)) | |||
* pre-commit script is optional ([#457](https://github.com/NLeSC/python-template/issues/457)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
* pre-commit script is optional ([#457](https://github.com/NLeSC/python-template/issues/457)) | |
* pre-commit script is optional [#457](https://github.com/NLeSC/python-template/issues/457) |
@@ -5,7 +5,7 @@ package_name: | |||
placeholder: my_python_package | |||
help: Enter the name of the Python package. | |||
validator: >- | |||
{% if not (package_name | regex_search('^[a-z][a-z0-9\_]+$')) %} | |||
{% if not (package_name | regex_search('^[A-Za-z][A-Za-z0-9\_]+$')) %} | |||
Package name must start with a letter, followed one or more letters, digits or underscores all lowercase |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Package name must start with a letter, followed one or more letters, digits or underscores all lowercase | |
Package name must start with a letter, followed one or more letters, digits or underscores |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @fdiblen See a couple of comments. After that good to go.
blocked by #621 |
Checklist before requesting a review
Type of change
Please delete options that are not relevant.
List of related issues or pull requests**
Refs:
Describe the changes made in this pull request
Package names containing uppercase are allowed.
Instructions to review the pull request
Install the requirements
Create a new package using the template
Create a local git repo to push to GitHub to trigger CI actions