add ZONEMD support #229
add ZONEMD support #229
Conversation
src/rdata/zonemd.rs
Outdated
| /// hashing function. | ||
| #[derive(Copy, Clone, Debug, Hash, Eq, PartialEq, PartialOrd, Ord)] | ||
| #[cfg_attr(feature = "serde", derive(serde::Serialize, serde::Deserialize))] | ||
| #[repr(u8)] |
There was a problem hiding this comment.
Does that actually work? I would assume the compiler needs to be able to distinguish between the unassigned and private variant both of which can carry a full u8.
There was a problem hiding this comment.
It only works with field-less enums. Removed.
Edit: It is required because of https://github.com/rust-lang/rust/blob/master/compiler/rustc_error_codes/src/error_codes/E0732.md
There was a problem hiding this comment.
I don’t think it makes too much sense to add the value to Simple, given that you convert explicitly in the From<_> impls.
There was a problem hiding this comment.
You are right. These are removed.
src/rdata/zonemd.rs
Outdated
| } | ||
| } | ||
|
|
||
| /// The Scheme is an 8-bit unsigned integer that identifies the |
There was a problem hiding this comment.
Could you start the docstring with a single one-line summary? This will then show in the index pages of the module and gives a hint as to what the type is for …
src/rdata/zonemd.rs
Outdated
| } | ||
| } | ||
|
|
||
| /// The Hash Algorithm is an 8-bit unsigned integer that identifies |
xofyarg
force-pushed
the
zonemd
branch
2 times, most recently
from
bebab87
to
0cda505
Compare
|
Thanks for the review, @partim. I've addressed all the comments, please take another look. |
This commit add support for ZONEMD record type, described in RFC 8976.
|
Thank you for the changes! Looking good now. Given that the record type enums are marked as non-exhaustive, I think this isn’t a breaking change and can be merged right away. |
Breaking changes * Move the `flatten_into` method for converting domain names into a straight, flat form into a new `FlattenInto` trait. This trait is only implemented for types that actually are or contain domain names. ([#216]) * Marked various methods and functions that return values without side effects as `#[must_use]`. ([#228] by [@WhyNotHugo]) * Changed the signature of `FoundSrvs::merge` to use a non-mut `other`. ([#232]) New * Added support for the ZONEMD record type. ([#229] by [@xofyarg]) * Re-exported the _octseq_ crate as `dep::octseq`. ([#230]) * Added a blanket impl for mut refs to `Composer`. ([#231] by [@xofyarg])
This commit add support for ZONEMD record type, described in RFC 8976.
Since root is rolling it out, there's no reason the standard is missing from the library :-p