Remove Sized constraint from tsig module types. #241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently the requirement of sized types means that Message<[u8]> cannot be used in tsig operations.
|
Thank you for the PR! You are, of course, correct that this module should also work on Please let us know if you need a release soon or if we can can wait a wee bit to collect a few more items. |
|
Thank you for such a fast review and pull! I'm not in any rush to see a release, I'm happy to let some other changes pool |
partim
added a commit
that referenced
this pull request
Nov 16, 2023
New * Removed the `Sized` bound for octets types used by the `tsig` module. ([#241] by [@torin-carey]) * Added an impl for `AsRef<Message<[u8]>>` for any message. ([#242] by [@torin-carey]) Bug fixes * Fixed in scanning absolute domain names from a zonefile that resulted in illegal wire data being produced. ([#240] by [@xofyarg)]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the requirement of sized types means that
Message<[u8]>cannot be used in TSIG operations using thetsigmodule.These constraints can be relaxed.