Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add AsRef impl for Record to allow for passing records by references when signing #288

Merged
merged 2 commits into from
Apr 3, 2024
Merged

add AsRef impl for Record to allow for passing records by references when signing #288

merged 2 commits into from
Apr 3, 2024

Commits on Mar 29, 2024

  1. add AsRef impl for Record 

    One of the use case is to allow for both owned or borrowed records
in the mutable slice when composing the signed data.

Without this, in some cases, the caller would have to clone records
if they only hold a slice of record references.
    @hunts
    hunts committed Mar 29, 2024
    Configuration menu
    Copy the full SHA
    d290854 View commit details
    Browse the repository at this point in the history

  2. chore: cargo fmt/clippy 

    The `Decoder<Builder>` is no longer gated by feature `bytes`, there is no
reason to only gate the `Default` impl.

Moved two uses into `zonefile` feature scope in zonemd tests.
    @hunts
    hunts committed Mar 29, 2024
    Configuration menu
    Copy the full SHA
    ca734bd View commit details
    Browse the repository at this point in the history