Add RR batching functionality. #383
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ComposeRequest and ComposeRequestMulti.
…G signing uses mock time during Stelline tests.
…rving doesn't do this yet and this still needs fixing, and (b) it violates the expectations of the TSIG Stelline test that verifies at a byte level the TSIG response signature.
…t the upcoming XFR support.
…t' into stelline-server-testing-changes
Co-authored-by: Ximon Eighteen <3304436+ximon18@users.noreply.github.com>
…t' into stelline-server-testing-changes
Add RFC 1996 "slave" side minimalistic NOTIFY request support, delegating the actual work to a caller supplied helper that implements a new Notifiable trait.
Philip-NLnetLabs
approved these changes
Sep 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Taken from the
xfrbranch in order to split PR #335 into several smaller PRs.This PR implements a "batcher" of resource records which can fill up an in-progress response until it is full then invoke a callback to send it before starting to fill the next response. This is useful for large multi-response answers to queries such as AXFR and IXFR.
Will be followed by an XFR specific batcher implementation that is used by the XFR middleware in the
xfrbranch.