Usability tweaks #397
Merged
Usability tweaks #397
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ion of tsig mod KeyStore changes which is good anyway as they would have been breaking changes to stable interfaces.
- Don't pass the key store around, we need only the signer when post-processing. - Get tid of the mutex, we don't need it. - Don't clone metadata when invoking a stream post-processing callback. - Add key_wrapper() fn to ServerTransaction, ServerSequence and SigningContext to allow access to the key by its original type (which might e.g. be Arc<Key> allowing the Arc to be cloned rather than a deep copy being made).
…noring the actual error code.
partim
reviewed
Oct 2, 2024
… well and not currently really needed.
partim
approved these changes
Oct 3, 2024
ximon18
added a commit
that referenced
this pull request
Oct 3, 2024
This PR adds a few trait impls and documentation. Specifically: * Add blanket `SendRequest` and `SendRequestMulti` impls for boxes. * Add `Display` impl to `tsig::Key`. * Add an `as_any` method and `Clone` and `Debug` impls to various zonetree types. * Add `AsRef<dyn ZoneStore>` to `Zone`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Various trait impls and other tweaks to enable more use cases.
Based on code that was originally in the
xfrbranch for now closed PR #335 which used these changes to implement theZoneMaintainer.