Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this PR an AXFR of a large zone was causing errors in the log like so:
This PR contains the following EDNS(0) related fixes:
This PR doesn't yet include tests that verify the fixes but with these changes the ISC EDNS Compliance Tester (https://ednscomp.isc.org/) approves of the domain
EdnsMiddlewareSvc
behaviour (whereas prior to this PR it detected multiple failure cases), reporting:One issue with this PR is that the configured push limit is cleared entirely. That's also how the
TsigMiddlewareSvc
code works, but that is likely to be the last middleware in the chain before the server, whileEdnsMiddlewareSvc
will likely be further along the chain. This means that in principle middleware that post-processes a response afterEdnsMiddlewareSvc
but beforeTsigMiddlewareSvc
could push more bytes into the response than should be allowed.A fix for this could be a sort of push/pop sequence of response limits pushed by each middleware on pre-process and popped on post-process, but that is not part of this PR.