Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support async storage #1152

Open
wants to merge 18 commits into
base: main
Choose a base branch
from
Open

Support async storage #1152

wants to merge 18 commits into from

Conversation

timbru
Copy link
Contributor

@timbru timbru commented Nov 6, 2023

This makes the KeyValueStore enum async, which, of course, has a rather big impact on the code base.

The enum delegates to KeyValueStoreImpl which is still sync. The actual Disk and Memory implementations are also sync. We can make this implementation async in a future a PR. We may be able to remove the indirection to the KeyValueStoreImpl enum then as well. We will see. When this is done, we can also port the kvx implementation for postgresql - albeit, using async.

Just mentioning this here now so that it is clear that there is more work, but I intentionally wanted to keep this PR a bit smaller so that it can be reviewed better.

@timbru timbru marked this pull request as draft November 6, 2023 13:51
Tim Bruijnzeels added 4 commits November 15, 2023 20:24
* Move KV into krill
* Move Storable to storage::types
* Embed used functions from kvx and convert from trait to enum.
@timbru timbru changed the title Support async storage (work in progress) Support async storage Nov 19, 2023
@timbru timbru marked this pull request as ready for review January 10, 2024 11:43
@partim partim deleted the branch main June 17, 2024 10:26
@partim partim closed this Jun 17, 2024
@partim partim mentioned this pull request Jun 17, 2024
@partim partim reopened this Jun 17, 2024
@partim partim changed the base branch from prep-0.15.0-rc1 to main June 17, 2024 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants