Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove the empty return for cssr #6000

Merged
merged 1 commit into from
Dec 4, 2023
Merged

remove the empty return for cssr #6000

merged 1 commit into from
Dec 4, 2023

Conversation

Zuhal-Ayob
Copy link
Collaborator

Work done

Tests

Does this PR include tests for the changes introduced?

  • Yes
  • No, I found it difficult to test
  • No, they are not required for this change

Copy link

codecov bot commented Dec 4, 2023

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (7e4df0e) 51.95% compared to head (9b18adf) 51.96%.

Files Patch % Lines
server/models/classes/establishment.js 28.57% 5 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             live    #6000   +/-   ##
=======================================
  Coverage   51.95%   51.96%           
=======================================
  Files        1141     1141           
  Lines       37928    37926    -2     
  Branches     5039     5039           
=======================================
+ Hits        19707    19708    +1     
+ Misses      13824    13821    -3     
  Partials     4397     4397           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@Jonopono123 Jonopono123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good stuff

@Zuhal-Ayob Zuhal-Ayob merged commit f97c5f7 into live Dec 4, 2023
4 of 5 checks passed
@Zuhal-Ayob Zuhal-Ayob deleted the fix/establishmentName branch December 4, 2023 15:18
@magicmilo magicmilo restored the fix/establishmentName branch January 2, 2024 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants