Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/delete training records #6015

Merged
merged 3 commits into from
Dec 14, 2023
Merged

Fix/delete training records #6015

merged 3 commits into from
Dec 14, 2023

Conversation

ssrome
Copy link
Collaborator

@ssrome ssrome commented Dec 14, 2023

Work done

  • Add function in add-edit-training to route to delete record as previous way caused issues
  • Update karma.conf to run ChromeHeadlessNoSandbox

Tests

Does this PR include tests for the changes introduced?

  • Yes
  • No, I found it difficult to test
  • No, they are not required for this change

Copy link

codecov bot commented Dec 14, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ae3e931) 52.17% compared to head (534511b) 52.18%.

Additional details and impacted files
@@           Coverage Diff           @@
##             live    #6015   +/-   ##
=======================================
  Coverage   52.17%   52.18%           
=======================================
  Files        1140     1140           
  Lines       37428    37431    +3     
  Branches     4566     4567    +1     
=======================================
+ Hits        19529    19532    +3     
  Misses      13978    13978           
  Partials     3921     3921           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@magicmilo magicmilo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good stuff

@ssrome ssrome merged commit 1c5c711 into live Dec 14, 2023
5 checks passed
@ssrome ssrome deleted the fix/deleteTrainingRecords branch December 14, 2023 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants