-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add a plugin option to support passing options cssnano v4 #73
Conversation
@@ -23,6 +23,9 @@ class OptimizeCssAssetsWebpackPlugin extends LastCallWebpackPlugin { | |||
this.options.cssProcessorOptions = !options || options.cssProcessorOptions === undefined ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this still being used?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, postcss needs the same options in old versions
{ from, to }
As a convenience, plugins also expose a process method so that you can use them as standalone tools.
cleaner.process(css, processOpts, pluginOpts)
// This is equivalent to:
postcss([ cleaner(pluginOpts) ]).process(css, processOpts)
from postcss api
Been having the issue with the option, and this PR completely solved it! +1 for merging this. |
Was thinking if this should be implemented with a If If But the ignoring What do you think? |
@NMFR There are 3 solutions now:
Idk which one would you guys prefer. |
I don't think solution Going with solution |
Many thx for the help |
for issue #69 #71
add a
cssProcessorPluginOptions
as a third arg passed to cssProcessor