Reimplement ATLAS Z0 7TEV 46FB Dataset

[ecole41]

This pull request is merging the two CC and CF datasets into one filter.py script.
Functions haves been added to produce the data central, kinematic and uncertainties yaml files for both of these datasets.

Old vs New Data

CC Dataset: https://vp.nnpdf.science/SpiOHitcS-2WggfpKcLW3Q==/

CF Dataset: https://vp.nnpdf.science/D3121rJ6RWG3IgyqViXJMw==/

Compatibility Check:

from validphys.api import API
import numpy as np
 
inp1 = {"dataset_input": {"dataset": "ATLASZRAP11CC"}, "theoryid": 40_000_000, "use_cuts": "internal", "t0pdfset": "NNPDF40_nnlo_as_01180", "use_t0": True}
inp2 = {"dataset_input": {"dataset": "ATLASZRAP11CC", "variant": "legacy"}, "theoryid": 40_000_000, "use_cuts": "internal", "t0pdfset": "NNPDF40_nnlo_as_01180", "use_t0": True}
 
covmat1 = API.covmat_from_systematics(**inp1)
covmat2 = API.covmat_from_systematics(**inp2)
 
t0_covmat1 = API.t0_covmat_from_systematics(**inp1)
t0_covmat2 = API.t0_covmat_from_systematics(**inp2)
 
result = np.all(np.isclose(covmat1, covmat2))
result_2 = np.all(np.isclose(t0_covmat1, t0_covmat2))

print('covmat', result)
print('t0_covmat', result_2)

inp3 = {"dataset_input": {"dataset": "ATLASWZRAP11CF"}, "theoryid": 40_000_000, "use_cuts": "internal", "t0pdfset": "NNPDF40_nnlo_as_01180", "use_t0": True}
inp4 = {"dataset_input": {"dataset": "ATLASWZRAP11CF", "variant": "legacy"}, "theoryid": 40_000_000, "use_cuts": "internal", "t0pdfset": "NNPDF40_nnlo_as_01180", "use_t0": True}
 
covmat3 = API.covmat_from_systematics(**inp3)
covmat4 = API.covmat_from_systematics(**inp4)
 
t0_covmat3 = API.t0_covmat_from_systematics(**inp3)
t0_covmat4 = API.t0_covmat_from_systematics(**inp4)
 
result3 = np.all(np.isclose(covmat3, covmat4))
result_4 = np.all(np.isclose(t0_covmat3, t0_covmat4))

print('covmat', result3)
print('t0_covmat', result_4)

[Out]:

covmat True
t0_covmat True
covmat True
t0_covmat True

[scarlehoff]

Hi @ecole41 this is not ready for rewview yet right? I see that the variables are still called k1/k2/k_i etc for instance.

[ecole41]

Hi @ecole41 this is not ready for rewview yet right? I see that the variables are still called k1/k2/k_i etc for instance.

No, this is not ready yet. I will keep working on it

[scarlehoff]

Ok! No problem! Is any of the PR finished? There are now many and I got a bit lost. So that I can review (and hopefully merge) the ones that are

[ecole41]

Ok! No problem! Is any of the PR finished? There are now many and I got a bit lost. So that I can review (and hopefully merge) the ones that are

Yes, #2178 and #2202 should be ready unless there is something that I have missed.

[ecole41]

This branch should be complete, but is failing the checks. I have merged from the master so am not sure why this is happening

[jacoterh]

This branch should be complete, but is failing the checks. I have merged from the master so am not sure why this is happening

Indeed, it's really odd - I don't see what's wrong with your metadata. The yaml file cannot be parsed for some reason. I'm looking into it.

[jacoterh]

I noticed that if you remove data_central from variants: legacy the tests pass again

[ecole41]

Ok, I will just check if changing the formatting of this helps

[jacoterh]

The tests pass now, excellent!

[jacoterh]

Please add also the inspire link

[jacoterh]

The version can be set to 1

[jacoterh]

Looks correct to me, if you also remove the comment ;-)

[jacoterh]

Looks like this is good to go after the minor comments I left are implemented. Thanks!