Reimplement DY

[peterkrack]

Things to fix

DYE866_Z0_800GEV:

• Central values differ.

DYE866_Z0_800GEV_DW_RATIO:

• Different values for the rapidity.

DYE605_Z0_38P8GEV_DW:

• 999 instead of 1000 replicas to determine uncertainties.

[Radonirinaunimi]

Hi @peterkrack! Happy new year and thanks for this!

Here are some preliminary comments:

• Could you please fix the metedata regarding the arXiv, inSpire, and HepData urls? These will be crucial when moving into Remove HepData raw tables from the repository #2228
• Could you make sure that the filters run properly. Currently, this is not the case as these filters contain some calls to non-existing functions.
• Add the following to the filters to properly format the floats:

  nnpdf/nnpdf_data/nnpdf_data/commondata/ATHENA_NC_45GEV_EP/filter.py

  Lines 12 to 14 in 3f59024

  	from nnpdf_data.filter_utils.utils import prettify_float
  	yaml.add_representer(float, prettify_float)

• Use pre-commit hooks https://pre-commit.com/ to make sure that all the files are properly formatted before each commit.

Could you please take of these first before I can move further into the details of the implementation?

[Radonirinaunimi]

Suggested change

from os import PathLike

Remove PathLike and use only pathlib.Path.

[Radonirinaunimi]

nnpdf_data.filter_utils.hera_utils.covmat_is_close is currently non-existing.

[Radonirinaunimi]

Suggested change

	from nnpdf_data.filter_utils.hera_utils import commondata, covmat_is_close
	from nnpdf_data.filter_utils.hera_utils import commondata

Same as above!

[Radonirinaunimi]

Hi @peterkrack, please let me know if there is anything I can help with in the meantime.

[Radonirinaunimi]

I was wondering if there are some updates regarding the pending issues above and whether some helps are needed?

[peterkrack]

I was wondering if there are some updates regarding the pending issues above and whether some helps are needed?

For DYE605_Z0_38P8GEV_DW is suspect it is a bug in the old buildmaster. The other two I have to figure out what exactly is causing the discrepancy between legacy and reimplementation.

[Radonirinaunimi]

I was wondering if there are some updates regarding the pending issues above and whether some helps are needed?

For DYE605_Z0_38P8GEV_DW is suspect it is a bug in the old buildmaster. The other two I have to figure out what exactly is causing the discrepancy between legacy and reimplementation.

I can also have a look in details, but would you be able to take care of #2248 (review) above?