Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMEPS Sync with Trigrid capability #122

Merged
merged 682 commits into from
Jul 26, 2024

Conversation

DeniseWorthen
Copy link
Collaborator

@DeniseWorthen DeniseWorthen commented Jul 1, 2024

Description of changes

Updates CMEPS to latest ESCOMP/main

Specific notes

Testing

Testing in UFS indicates that all tests which compare mediator restart or history files will fail due to the presence of a new fraction field in the FBfrac (atmFrac_lfrin). All other compared files are B4B. See full testing in associated UFS PR ufs-community/ufs-weather-model#2352

jedwards4b and others added 30 commits May 19, 2023 09:16
* remove swnet to ocean from custom_nems
* set optional use of nextswday
* get med history working w/o aofluxes
make xgrid default and fix sw flux to mom ocn
…ig_option

Add check for nans config option
testing indicates we are not yet ready for xgrid
* flux_albav moved to _init
* use_nextswcday for using clock instead of scalar field
* min_albedo for setting min albedo used max(min_albedo,....)
* giving a min_albedo value sets logical use_min_albedo, otherwise
false and min_albedo=0
* set mean albdif and albdir via config. If not present, defaults to
current values
@DeniseWorthen DeniseWorthen requested a review from dpsarmie July 22, 2024 17:53
@DeniseWorthen
Copy link
Collaborator Author

DeniseWorthen commented Jul 22, 2024

Changes w/in the sub-dirs cesm, cime-config and in files fldsExchange_cesm.F90 and fd_cesm.yaml are NA for UFS.

Copy link
Collaborator

@dpsarmie dpsarmie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First batch or reviews, will get to the rest later today/tomorrow

mediator/fd_cesm.yaml Show resolved Hide resolved
Copy link
Collaborator

@dpsarmie dpsarmie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still have a handful of files left to look at but pushing this batch to save progress

mediator/med_internalstate_mod.F90 Show resolved Hide resolved
mediator/med_internalstate_mod.F90 Show resolved Hide resolved
@zach1221
Copy link

Hi, @DeniseWorthen . Testing is complete on WM PR 2352. Feel free to merge this PR.

@DeniseWorthen DeniseWorthen merged commit f13e16e into NOAA-EMC:emc/develop Jul 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sync CMEPS with ESCOMP repository; add trigrid capability