Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update components and app #14

Merged
merged 35 commits into from
May 12, 2020

Conversation

DeniseWorthen
Copy link
Collaborator

@DeniseWorthen DeniseWorthen commented May 5, 2020

  • Updates DATM to develop branch with updates PR Port DATM-MOM6-CICE5 to Orion #8: (DATM updates and fixes NEMSdatm#8)

  • Adds utility to create SCRIP grid format file from grid contained in a CFSR or GEFS file

  • Updates CICE to current develop (includes orion port)

  • Updates MOM6 to current develop (includes orion port)

  • Updates FMS

  • Updates compset tests to be align with S2S for easier transition to rt.sh

Associated NEMS PR #57. The NEMS PR must be merged before this PR can be merged.

  • After this merge, the NEMS driver will have the capability to use CMEPS as an alternative mediator, although the CMEPS mediator itself will need updates for use with the DATM.

DeniseWorthen and others added 30 commits April 9, 2020 20:28
Feature/hera_preprocess_gefs (#7)
in datm_data_table to match non-CMEPS version
attributes and printing for make_scripgrid.ncl
to be able to create and test baselines; add restart
settings to nems.configure
@DeniseWorthen
Copy link
Collaborator Author

The associated NEMS PR is now # 61

@DeniseWorthen
Copy link
Collaborator Author

NEMS has been updated with i2a fix; regression tests and logs for hera will be added.

This was linked to issues May 12, 2020
@flampouris flampouris self-requested a review May 12, 2020 12:26
Copy link
Collaborator

@flampouris flampouris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The conf/configure.coupled.orion.intel is missing.

If it helps, I have created the configure.*.orion.intel, are located at
/work/noaa/marine/Stylianos.Flampouris/godas/src/DATM-MOM6-CICE5.fd/conf

@DeniseWorthen
Copy link
Collaborator Author

New baselines have been created on Hera. This PR is now ready for review.

@@ -3,7 +3,8 @@
url = https://github.com/NOAA-EMC/CICE5
[submodule "FMS"]
path = FMS
url = https://github.com/NOAA-EMC/FMS
url = https://github.com/NOAA-GFDL/FMS
branch = master
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check out tag 2019.01 revision: 708b8d5, which is used in s2s. We are working on bringing in the latest GFDL dycore with FMS release tag 2020.02 in ufs-weather-model. GFDL did test ufs-weather-model for FMS release, we do not directly use the top of master in ufs applications.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When I checkout this branch, I do see tag 2019.01 and 708b8d5 as the hash.

The branch=master also is present in the ufs-s2s-model .gitmodules.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The FMS version is correct.

@DeniseWorthen DeniseWorthen merged commit 50315c3 into NOAA-EMC:develop May 12, 2020
DeniseWorthen added a commit to DeniseWorthen/DATM-MOM6-CICE5 that referenced this pull request May 12, 2020
@DeniseWorthen DeniseWorthen deleted the feature/updbl branch May 12, 2020 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

update components Port DATM-MOM6-CICE5 to Orion
4 participants