Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Jet support to fit2obs #5

Closed
KateFriedman-NOAA opened this issue Feb 28, 2023 · 10 comments · Fixed by #11
Closed

Add Jet support to fit2obs #5

KateFriedman-NOAA opened this issue Feb 28, 2023 · 10 comments · Fixed by #11
Assignees
Labels
enhancement New feature or request

Comments

@KateFriedman-NOAA
Copy link
Member

@DavidHuber-NOAA is working on porting global-workflow to RDHPCS Jet. Add in support for building and running fit2obs on Jet.

Related to issue #4 being worked on by @KateFriedman-NOAA.

@DavidHuber-NOAA
Copy link
Contributor

I am giving this a test run presently.

@KateFriedman-NOAA
Copy link
Member Author

I have edits in a branch for functionality on WCOSS2. Mind seeing if those edits work on Jet? I just committed them to my branch: https://github.com/KateFriedman-NOAA/Fit2Obs/tree/feature/wcoss2_jet_support

Still testing my branch on WCOSS2 with a copy of global-workflow develop but so far it appears to be working. Need to look at logs for silent errors still and have Jack look at output.

@DavidHuber-NOAA
Copy link
Contributor

@KateFriedman-NOAA Sure will do. Thanks for the heads up.

DavidHuber-NOAA added a commit to DavidHuber-NOAA/Fit2Obs that referenced this issue Feb 28, 2023
@DavidHuber-NOAA
Copy link
Contributor

@KateFriedman-NOAA I ran the workflow overnight through 12 cycles and the fit2obs jobs are running without error. However, I am only seeing fits for forecast hours 00 and 06 being generated in archive/EXP/fits. Also, the horiz/fcs directory in archive/ is not being populated.

DavidHuber-NOAA added a commit to DavidHuber-NOAA/Fit2Obs that referenced this issue Mar 2, 2023
@DavidHuber-NOAA
Copy link
Contributor

@KateFriedman-NOAA Disregard, I am seeing out of memory errors on kjet. I'm going to investigate further.

DavidHuber-NOAA added a commit to DavidHuber-NOAA/Fit2Obs that referenced this issue Mar 2, 2023
@DavidHuber-NOAA
Copy link
Contributor

Fixed by requesting all available memory on the node (--mem=0). I'm now seeing other hours populate in archive/ and horiz/fcs is populating as well.

@KateFriedman-NOAA
Copy link
Member Author

Excellent! This is good resource info to know. When the vrfy job finally gets broken into separate jobs (hopefully soon) we'll need to know the resources to assign to the individual fit2obs job in the workflow. Thanks for the update!

@DavidHuber-NOAA
Copy link
Contributor

@jack-woollen Was able to verify that a recent test of Fit2Obs generated outputs as expected on Jet. PR forthcoming.

@jack-woollen
Copy link
Collaborator

@KateFriedman-NOAA I reviewed the PR and have one problem. This morning I pushed changes to the repo that added back the .x on the executables, per Rahul. Some of the changes in the pull request overwrite some of those changes. Can you merge the new develop branch into your changes and make another PR? Sorry about the mixup!

@KateFriedman-NOAA
Copy link
Member Author

@jack-woollen Oh, I just resolved conflicts and undid that in my branch (not knowing about that other commit). I'll redo that merge from develop and note it in this PR when done. Thanks for letting me know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
3 participants