Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add PYTHONPATH in the j-job prep #242

Closed
guillaumevernieres opened this issue Dec 13, 2022 · 1 comment
Closed

Add PYTHONPATH in the j-job prep #242

guillaumevernieres opened this issue Dec 13, 2022 · 1 comment
Assignees
@AndrewEichmann-NOAA
Labels
soca
Milestone
godas, February 2023

Comments

@guillaumevernieres
Copy link
Contributor

guillaumevernieres commented Dec 13, 2022 •
edited
Loading 

    This comment still applies :-), set this at the j-job with `$PYTHONPATH`

Originally posted by @CoryMartin-NOAA in #234 (comment)

The ush python path need to be move from scripts/exgdas_global_marine_analysis_prep.py to the JGDAS_GLOBAL_OCEAN_ANALYSIS_PREP j-job and appended to PYTHONPATH.
@guillaumevernieres guillaumevernieres mentioned this issue Dec 13, 2022
Merged
@guillaumevernieres
Copy link
Contributor Author

@AndrewEichmann-NOAA , ping me and @ShastriPaturi when you have time to look at this.
It should be straight forward:

  • g-w: What @CoryMartin-NOAA says in the description
  • GDASApp:
    • remove the python path to ufsda in the prep script
    • append the ufsda path to the PYTHONPATH env. var. in the CMakeLists.txt for the testing of the prep script.

This was referenced Jan 30, 2023
Merged
Merged
WalterKolczynski-NOAA pushed a commit to NOAA-EMC/global-workflow that referenced this issue Jan 31, 2023
@AndrewEichmann-NOAA
Add PYTHONPATH to soca ocean prep jjob (#1292)
6b5d92d 
Adds the UFSDA location to PYTHONPATH in soca prep jjob so the path building is not done in script.

Refs: NOAA-EMC/GDASApp#242 and NOAA-EMC/GDASApp#234

The issues require changes also to GDASApp, but this PR will not break GDASApp as is
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AndrewEichmann-NOAA AndrewEichmann-NOAA

Labels
soca
Projects
None yet
Milestone
godas, February 2023
Development

No branches or pull requests
2 participants
@guillaumevernieres @AndrewEichmann-NOAA