Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add lgetkf observer and solver templates #1252

Merged
merged 11 commits into from
Aug 20, 2024

Conversation

RussTreadon-NOAA
Copy link
Contributor

This PR adds prototype templates to run the lgetkf in observation and solver modes. Doing so necessitates updates to parm/jcb-algorithms and parm/jcb-gdas.

The PR also changes the iodafile in ush/ioda/bufr2ioda/bufr2ioda_acft_profiles_prepbufr.py to be consistent with the jcb-gdas template.

Resolves #1249

Dependencies

  • jcb-algorithms PR #4
  • jcb-gdas PR #23

DO NOT MERGE THIS PR into GDASApp develop until

  1. the above jcb PRs are merged into their respective develop
  2. the jcb hashes in this PR are updated

@RussTreadon-NOAA
Copy link
Contributor Author

RussTreadon-NOAA commented Aug 17, 2024

Hera ctests

Install GDASApp feature/ensda_obs @ 8c33ad8 inside g-w feature/ensda_obs at cf082b4. Run test_gdasapp ctests with the following results

Test project /scratch1/NCEPDEV/da/Russ.Treadon/git/global-workflow/ensda_obs/sorc/gdas.cd/build
      Start 1531: test_gdasapp_util_coding_norms
 1/44 Test #1531: test_gdasapp_util_coding_norms ........................   Passed    2.38 sec
      Start 1532: test_gdasapp_util_ioda_example
 2/44 Test #1532: test_gdasapp_util_ioda_example ........................   Passed    3.76 sec
      Start 1533: test_gdasapp_util_prepdata
 3/44 Test #1533: test_gdasapp_util_prepdata ............................   Passed    1.14 sec
      Start 1534: test_gdasapp_util_rads2ioda
 4/44 Test #1534: test_gdasapp_util_rads2ioda ...........................   Passed    0.18 sec
      Start 1535: test_gdasapp_util_ghrsst2ioda
 5/44 Test #1535: test_gdasapp_util_ghrsst2ioda .........................   Passed    0.14 sec
      Start 1536: test_gdasapp_util_rtofstmp
 6/44 Test #1536: test_gdasapp_util_rtofstmp ............................   Passed    0.95 sec
      Start 1537: test_gdasapp_util_rtofssal
 7/44 Test #1537: test_gdasapp_util_rtofssal ............................   Passed    0.77 sec
      Start 1538: test_gdasapp_util_smap2ioda
 8/44 Test #1538: test_gdasapp_util_smap2ioda ...........................   Passed    0.14 sec
      Start 1539: test_gdasapp_util_smos2ioda
 9/44 Test #1539: test_gdasapp_util_smos2ioda ...........................   Passed    0.14 sec
      Start 1540: test_gdasapp_util_viirsaod2ioda
10/44 Test #1540: test_gdasapp_util_viirsaod2ioda .......................   Passed    0.15 sec
      Start 1541: test_gdasapp_util_icecamsr2ioda
11/44 Test #1541: test_gdasapp_util_icecamsr2ioda .......................   Passed    0.14 sec
      Start 1542: test_gdasapp_util_icecmirs2ioda
12/44 Test #1542: test_gdasapp_util_icecmirs2ioda .......................   Passed    0.14 sec
      Start 1880: test_gdasapp_check_python_norms
13/44 Test #1880: test_gdasapp_check_python_norms .......................   Passed    2.86 sec
      Start 1881: test_gdasapp_check_yaml_keys
14/44 Test #1881: test_gdasapp_check_yaml_keys ..........................   Passed    0.20 sec
      Start 1882: test_gdasapp_jedi_increment_to_fv3
15/44 Test #1882: test_gdasapp_jedi_increment_to_fv3 ....................   Passed    0.63 sec
      Start 1883: test_gdasapp_fv3jedi_fv3inc
16/44 Test #1883: test_gdasapp_fv3jedi_fv3inc ...........................   Passed   16.74 sec
      Start 1884: test_gdasapp_soca_nsst_increment_to_mom6
17/44 Test #1884: test_gdasapp_soca_nsst_increment_to_mom6 ..............   Passed    5.02 sec
      Start 1885: test_gdasapp_soca_prep
18/44 Test #1885: test_gdasapp_soca_prep ................................   Passed    4.36 sec
      Start 1886: test_gdasapp_soca_run_clean
19/44 Test #1886: test_gdasapp_soca_run_clean ...........................   Passed    0.10 sec
      Start 1887: test_gdasapp_soca_setup_obsprep
20/44 Test #1887: test_gdasapp_soca_setup_obsprep .......................   Passed   32.77 sec
      Start 1888: test_gdasapp_soca_JGLOBAL_PREP_OCEAN_OBS
21/44 Test #1888: test_gdasapp_soca_JGLOBAL_PREP_OCEAN_OBS ..............   Passed   43.33 sec
      Start 1889: test_gdasapp_soca_JGLOBAL_MARINE_BMAT
22/44 Test #1889: test_gdasapp_soca_JGLOBAL_MARINE_BMAT .................   Passed   74.35 sec
      Start 1890: test_gdasapp_soca_JGDAS_GLOBAL_OCEAN_ANALYSIS_PREP
23/44 Test #1890: test_gdasapp_soca_JGDAS_GLOBAL_OCEAN_ANALYSIS_PREP ....   Passed   42.43 sec
      Start 1891: test_gdasapp_soca_JGDAS_GLOBAL_OCEAN_ANALYSIS_RUN
24/44 Test #1891: test_gdasapp_soca_JGDAS_GLOBAL_OCEAN_ANALYSIS_RUN .....   Passed   42.35 sec
      Start 1892: test_gdasapp_soca_copy_scratch
25/44 Test #1892: test_gdasapp_soca_copy_scratch ........................   Passed    0.29 sec
      Start 1893: test_gdasapp_soca_JGDAS_GLOBAL_OCEAN_ANALYSIS_CHKPT
26/44 Test #1893: test_gdasapp_soca_JGDAS_GLOBAL_OCEAN_ANALYSIS_CHKPT ...   Passed   42.41 sec
      Start 1894: test_gdasapp_soca_JGDAS_GLOBAL_OCEAN_ANALYSIS_POST
27/44 Test #1894: test_gdasapp_soca_JGDAS_GLOBAL_OCEAN_ANALYSIS_POST ....   Passed   42.36 sec
      Start 1895: test_gdasapp_snow_create_ens
28/44 Test #1895: test_gdasapp_snow_create_ens ..........................   Passed    1.43 sec
      Start 1896: test_gdasapp_snow_imsproc
29/44 Test #1896: test_gdasapp_snow_imsproc .............................   Passed    3.46 sec
      Start 1897: test_gdasapp_snow_apply_jediincr
30/44 Test #1897: test_gdasapp_snow_apply_jediincr ......................   Passed    5.60 sec
      Start 1898: test_gdasapp_snow_letkfoi_snowda
31/44 Test #1898: test_gdasapp_snow_letkfoi_snowda ......................   Passed   11.26 sec
      Start 1899: test_gdasapp_convert_bufr_adpsfc_snow
32/44 Test #1899: test_gdasapp_convert_bufr_adpsfc_snow .................   Passed    3.64 sec
      Start 1900: test_gdasapp_convert_bufr_adpsfc
33/44 Test #1900: test_gdasapp_convert_bufr_adpsfc ......................   Passed    3.63 sec
      Start 1901: test_gdasapp_convert_gsi_satbias
34/44 Test #1901: test_gdasapp_convert_gsi_satbias ......................   Passed    5.02 sec
      Start 1902: test_gdasapp_setup_atm_cycled_exp
35/44 Test #1902: test_gdasapp_setup_atm_cycled_exp .....................   Passed    0.87 sec
      Start 1903: test_gdasapp_atm_jjob_var_init
36/44 Test #1903: test_gdasapp_atm_jjob_var_init ........................   Passed   47.74 sec
      Start 1904: test_gdasapp_atm_jjob_var_run
37/44 Test #1904: test_gdasapp_atm_jjob_var_run .........................   Passed   74.30 sec
      Start 1905: test_gdasapp_atm_jjob_var_inc
38/44 Test #1905: test_gdasapp_atm_jjob_var_inc .........................   Passed   74.62 sec
      Start 1906: test_gdasapp_atm_jjob_var_final
39/44 Test #1906: test_gdasapp_atm_jjob_var_final .......................   Passed   42.33 sec
      Start 1907: test_gdasapp_atm_jjob_ens_init
40/44 Test #1907: test_gdasapp_atm_jjob_ens_init ........................   Passed   47.37 sec
      Start 1908: test_gdasapp_atm_jjob_ens_run
41/44 Test #1908: test_gdasapp_atm_jjob_ens_run .........................   Passed  459.39 sec
      Start 1909: test_gdasapp_atm_jjob_ens_inc
42/44 Test #1909: test_gdasapp_atm_jjob_ens_inc .........................   Passed  106.34 sec
      Start 1910: test_gdasapp_atm_jjob_ens_final
43/44 Test #1910: test_gdasapp_atm_jjob_ens_final .......................   Passed   42.32 sec
      Start 1911: test_gdasapp_aero_gen_3dvar_yaml
44/44 Test #1911: test_gdasapp_aero_gen_3dvar_yaml ......................   Passed    0.49 sec

100% tests passed, 0 tests failed out of 44

Label Time Summary:
gdas-utils    =  10.04 sec*proc (12 tests)
script        =  10.04 sec*proc (12 tests)

Total Test time (real) = 1290.66 sec

@RussTreadon-NOAA
Copy link
Contributor Author

Hercules ctests

Install GDASApp feature/ensda_obs @ 8c33ad8 inside g-w feature/ensda_obs at cf082b4. Run test_gdasapp ctests with the following results

Test project /work/noaa/da/rtreadon/git/global-workflow/ensda_obs/sorc/gdas.cd/build
      Start 1532: test_gdasapp_util_coding_norms
 1/44 Test #1532: test_gdasapp_util_coding_norms ........................   Passed    5.11 sec
      Start 1533: test_gdasapp_util_ioda_example
 2/44 Test #1533: test_gdasapp_util_ioda_example ........................   Passed    8.02 sec
      Start 1534: test_gdasapp_util_prepdata
 3/44 Test #1534: test_gdasapp_util_prepdata ............................   Passed    5.06 sec
      Start 1535: test_gdasapp_util_rads2ioda
 4/44 Test #1535: test_gdasapp_util_rads2ioda ...........................   Passed    0.24 sec
      Start 1536: test_gdasapp_util_ghrsst2ioda
 5/44 Test #1536: test_gdasapp_util_ghrsst2ioda .........................   Passed    0.11 sec
      Start 1537: test_gdasapp_util_rtofstmp
 6/44 Test #1537: test_gdasapp_util_rtofstmp ............................   Passed    1.80 sec
      Start 1538: test_gdasapp_util_rtofssal
 7/44 Test #1538: test_gdasapp_util_rtofssal ............................   Passed    0.65 sec
      Start 1539: test_gdasapp_util_smap2ioda
 8/44 Test #1539: test_gdasapp_util_smap2ioda ...........................   Passed    0.10 sec
      Start 1540: test_gdasapp_util_smos2ioda
 9/44 Test #1540: test_gdasapp_util_smos2ioda ...........................   Passed    0.10 sec
      Start 1541: test_gdasapp_util_viirsaod2ioda
10/44 Test #1541: test_gdasapp_util_viirsaod2ioda .......................   Passed    0.09 sec
      Start 1542: test_gdasapp_util_icecamsr2ioda
11/44 Test #1542: test_gdasapp_util_icecamsr2ioda .......................   Passed    0.10 sec
      Start 1543: test_gdasapp_util_icecmirs2ioda
12/44 Test #1543: test_gdasapp_util_icecmirs2ioda .......................   Passed    0.09 sec
      Start 1881: test_gdasapp_check_python_norms
13/44 Test #1881: test_gdasapp_check_python_norms .......................   Passed    3.52 sec
      Start 1882: test_gdasapp_check_yaml_keys
14/44 Test #1882: test_gdasapp_check_yaml_keys ..........................   Passed    1.63 sec
      Start 1883: test_gdasapp_jedi_increment_to_fv3
15/44 Test #1883: test_gdasapp_jedi_increment_to_fv3 ....................   Passed   12.83 sec
      Start 1884: test_gdasapp_fv3jedi_fv3inc
16/44 Test #1884: test_gdasapp_fv3jedi_fv3inc ...........................   Passed   24.38 sec
      Start 1885: test_gdasapp_soca_nsst_increment_to_mom6
17/44 Test #1885: test_gdasapp_soca_nsst_increment_to_mom6 ..............   Passed   56.61 sec
      Start 1886: test_gdasapp_soca_prep
18/44 Test #1886: test_gdasapp_soca_prep ................................   Passed    2.57 sec
      Start 1887: test_gdasapp_soca_run_clean
19/44 Test #1887: test_gdasapp_soca_run_clean ...........................   Passed    0.08 sec
      Start 1888: test_gdasapp_soca_setup_obsprep
20/44 Test #1888: test_gdasapp_soca_setup_obsprep .......................   Passed    9.84 sec
      Start 1889: test_gdasapp_soca_JGLOBAL_PREP_OCEAN_OBS
21/44 Test #1889: test_gdasapp_soca_JGLOBAL_PREP_OCEAN_OBS ..............   Passed  331.31 sec
      Start 1890: test_gdasapp_soca_JGLOBAL_MARINE_BMAT
22/44 Test #1890: test_gdasapp_soca_JGLOBAL_MARINE_BMAT .................   Passed  394.22 sec
      Start 1891: test_gdasapp_soca_JGDAS_GLOBAL_OCEAN_ANALYSIS_PREP
23/44 Test #1891: test_gdasapp_soca_JGDAS_GLOBAL_OCEAN_ANALYSIS_PREP ....   Passed  202.20 sec
      Start 1892: test_gdasapp_soca_JGDAS_GLOBAL_OCEAN_ANALYSIS_RUN
24/44 Test #1892: test_gdasapp_soca_JGDAS_GLOBAL_OCEAN_ANALYSIS_RUN .....   Passed  298.21 sec
      Start 1893: test_gdasapp_soca_copy_scratch
25/44 Test #1893: test_gdasapp_soca_copy_scratch ........................   Passed    0.34 sec
      Start 1894: test_gdasapp_soca_JGDAS_GLOBAL_OCEAN_ANALYSIS_CHKPT
26/44 Test #1894: test_gdasapp_soca_JGDAS_GLOBAL_OCEAN_ANALYSIS_CHKPT ...   Passed  330.23 sec
      Start 1895: test_gdasapp_soca_JGDAS_GLOBAL_OCEAN_ANALYSIS_POST
27/44 Test #1895: test_gdasapp_soca_JGDAS_GLOBAL_OCEAN_ANALYSIS_POST ....   Passed  266.21 sec
      Start 1896: test_gdasapp_snow_create_ens
28/44 Test #1896: test_gdasapp_snow_create_ens ..........................   Passed    1.50 sec
      Start 1897: test_gdasapp_snow_imsproc
29/44 Test #1897: test_gdasapp_snow_imsproc .............................   Passed    3.93 sec
      Start 1898: test_gdasapp_snow_apply_jediincr
30/44 Test #1898: test_gdasapp_snow_apply_jediincr ......................   Passed    4.90 sec
      Start 1899: test_gdasapp_snow_letkfoi_snowda
31/44 Test #1899: test_gdasapp_snow_letkfoi_snowda ......................   Passed   34.39 sec
      Start 1900: test_gdasapp_convert_bufr_adpsfc_snow
32/44 Test #1900: test_gdasapp_convert_bufr_adpsfc_snow .................   Passed    3.26 sec
      Start 1901: test_gdasapp_convert_bufr_adpsfc
33/44 Test #1901: test_gdasapp_convert_bufr_adpsfc ......................   Passed    2.97 sec
      Start 1902: test_gdasapp_convert_gsi_satbias
34/44 Test #1902: test_gdasapp_convert_gsi_satbias ......................   Passed    4.25 sec
      Start 1903: test_gdasapp_setup_atm_cycled_exp
35/44 Test #1903: test_gdasapp_setup_atm_cycled_exp .....................   Passed    0.54 sec
      Start 1904: test_gdasapp_atm_jjob_var_init
36/44 Test #1904: test_gdasapp_atm_jjob_var_init ........................   Passed  108.93 sec
      Start 1905: test_gdasapp_atm_jjob_var_run
37/44 Test #1905: test_gdasapp_atm_jjob_var_run .........................   Passed  106.16 sec
      Start 1906: test_gdasapp_atm_jjob_var_inc
38/44 Test #1906: test_gdasapp_atm_jjob_var_inc .........................   Passed   42.16 sec
      Start 1907: test_gdasapp_atm_jjob_var_final
39/44 Test #1907: test_gdasapp_atm_jjob_var_final .......................   Passed   74.16 sec
      Start 1908: test_gdasapp_atm_jjob_ens_init
40/44 Test #1908: test_gdasapp_atm_jjob_ens_init ........................   Passed   76.90 sec
      Start 1909: test_gdasapp_atm_jjob_ens_run
41/44 Test #1909: test_gdasapp_atm_jjob_ens_run .........................   Passed  490.20 sec
      Start 1910: test_gdasapp_atm_jjob_ens_inc
42/44 Test #1910: test_gdasapp_atm_jjob_ens_inc .........................   Passed  106.17 sec
      Start 1911: test_gdasapp_atm_jjob_ens_final
43/44 Test #1911: test_gdasapp_atm_jjob_ens_final .......................   Passed   74.17 sec
      Start 1912: test_gdasapp_aero_gen_3dvar_yaml
44/44 Test #1912: test_gdasapp_aero_gen_3dvar_yaml ......................   Passed    0.43 sec

100% tests passed, 0 tests failed out of 44

Label Time Summary:
gdas-utils    =  21.47 sec*proc (12 tests)
script        =  21.47 sec*proc (12 tests)

Total Test time (real) = 3091.10 sec

@RussTreadon-NOAA
Copy link
Contributor Author

This PR is ready for review. This PR must be approved and merged into GDASApp develop before g-w PR #2833 is marked Ready for Review.

@RussTreadon-NOAA
Copy link
Contributor Author

Realize that I should add letkf observer and solver ctests to tests/atm/global-workflow Work to do so has begun. Given this, please hold off on formal reviews since this development is not complete.

@RussTreadon-NOAA
Copy link
Contributor Author

Hera and Hercules ctests
Install feature/ensda_obs at bd150cd inside g-w feature/ensda_obs at 218c851. Run ctests. All 46 tests pass on both machines

Hera results

Test project /scratch1/NCEPDEV/da/Russ.Treadon/git/global-workflow/ensda_obs/sorc/gdas.cd/build
      Start 1531: test_gdasapp_util_coding_norms
 1/46 Test #1531: test_gdasapp_util_coding_norms ........................   Passed    7.04 sec
      Start 1532: test_gdasapp_util_ioda_example
 2/46 Test #1532: test_gdasapp_util_ioda_example ........................   Passed    2.23 sec
      Start 1533: test_gdasapp_util_prepdata
 3/46 Test #1533: test_gdasapp_util_prepdata ............................   Passed    2.22 sec
      Start 1534: test_gdasapp_util_rads2ioda
 4/46 Test #1534: test_gdasapp_util_rads2ioda ...........................   Passed    0.30 sec
      Start 1535: test_gdasapp_util_ghrsst2ioda
 5/46 Test #1535: test_gdasapp_util_ghrsst2ioda .........................   Passed    0.20 sec
      Start 1536: test_gdasapp_util_rtofstmp
 6/46 Test #1536: test_gdasapp_util_rtofstmp ............................   Passed    1.13 sec
      Start 1537: test_gdasapp_util_rtofssal
 7/46 Test #1537: test_gdasapp_util_rtofssal ............................   Passed    0.91 sec
      Start 1538: test_gdasapp_util_smap2ioda
 8/46 Test #1538: test_gdasapp_util_smap2ioda ...........................   Passed    0.20 sec
      Start 1539: test_gdasapp_util_smos2ioda
 9/46 Test #1539: test_gdasapp_util_smos2ioda ...........................   Passed    0.20 sec
      Start 1540: test_gdasapp_util_viirsaod2ioda
10/46 Test #1540: test_gdasapp_util_viirsaod2ioda .......................   Passed    0.22 sec
      Start 1541: test_gdasapp_util_icecamsr2ioda
11/46 Test #1541: test_gdasapp_util_icecamsr2ioda .......................   Passed    0.19 sec
      Start 1542: test_gdasapp_util_icecmirs2ioda
12/46 Test #1542: test_gdasapp_util_icecmirs2ioda .......................   Passed    0.22 sec
      Start 1880: test_gdasapp_check_python_norms
13/46 Test #1880: test_gdasapp_check_python_norms .......................   Passed    4.97 sec
      Start 1881: test_gdasapp_check_yaml_keys
14/46 Test #1881: test_gdasapp_check_yaml_keys ..........................   Passed    0.29 sec
      Start 1882: test_gdasapp_jedi_increment_to_fv3
15/46 Test #1882: test_gdasapp_jedi_increment_to_fv3 ....................   Passed    1.17 sec
      Start 1883: test_gdasapp_fv3jedi_fv3inc
16/46 Test #1883: test_gdasapp_fv3jedi_fv3inc ...........................   Passed   16.46 sec
      Start 1884: test_gdasapp_soca_nsst_increment_to_mom6
17/46 Test #1884: test_gdasapp_soca_nsst_increment_to_mom6 ..............   Passed    6.92 sec
      Start 1885: test_gdasapp_soca_prep
18/46 Test #1885: test_gdasapp_soca_prep ................................   Passed    7.24 sec
      Start 1886: test_gdasapp_soca_run_clean
19/46 Test #1886: test_gdasapp_soca_run_clean ...........................   Passed    0.06 sec
      Start 1887: test_gdasapp_soca_setup_obsprep
20/46 Test #1887: test_gdasapp_soca_setup_obsprep .......................   Passed   24.82 sec
      Start 1888: test_gdasapp_soca_JGLOBAL_PREP_OCEAN_OBS
21/46 Test #1888: test_gdasapp_soca_JGLOBAL_PREP_OCEAN_OBS ..............   Passed  813.64 sec
      Start 1889: test_gdasapp_soca_JGLOBAL_MARINE_BMAT
22/46 Test #1889: test_gdasapp_soca_JGLOBAL_MARINE_BMAT .................   Passed   74.50 sec
      Start 1890: test_gdasapp_soca_JGDAS_GLOBAL_OCEAN_ANALYSIS_PREP
23/46 Test #1890: test_gdasapp_soca_JGDAS_GLOBAL_OCEAN_ANALYSIS_PREP ....   Passed   42.43 sec
      Start 1891: test_gdasapp_soca_JGDAS_GLOBAL_OCEAN_ANALYSIS_RUN
24/46 Test #1891: test_gdasapp_soca_JGDAS_GLOBAL_OCEAN_ANALYSIS_RUN .....   Passed   42.39 sec
      Start 1892: test_gdasapp_soca_copy_scratch
25/46 Test #1892: test_gdasapp_soca_copy_scratch ........................   Passed    0.43 sec
      Start 1893: test_gdasapp_soca_JGDAS_GLOBAL_OCEAN_ANALYSIS_CHKPT
26/46 Test #1893: test_gdasapp_soca_JGDAS_GLOBAL_OCEAN_ANALYSIS_CHKPT ...   Passed   42.96 sec
      Start 1894: test_gdasapp_soca_JGDAS_GLOBAL_OCEAN_ANALYSIS_POST
27/46 Test #1894: test_gdasapp_soca_JGDAS_GLOBAL_OCEAN_ANALYSIS_POST ....   Passed   74.43 sec
      Start 1895: test_gdasapp_snow_create_ens
28/46 Test #1895: test_gdasapp_snow_create_ens ..........................   Passed    1.51 sec
      Start 1896: test_gdasapp_snow_imsproc
29/46 Test #1896: test_gdasapp_snow_imsproc .............................   Passed    4.15 sec
      Start 1897: test_gdasapp_snow_apply_jediincr
30/46 Test #1897: test_gdasapp_snow_apply_jediincr ......................   Passed    6.04 sec
      Start 1898: test_gdasapp_snow_letkfoi_snowda
31/46 Test #1898: test_gdasapp_snow_letkfoi_snowda ......................   Passed   10.13 sec
      Start 1899: test_gdasapp_convert_bufr_adpsfc_snow
32/46 Test #1899: test_gdasapp_convert_bufr_adpsfc_snow .................   Passed    3.48 sec
      Start 1900: test_gdasapp_convert_bufr_adpsfc
33/46 Test #1900: test_gdasapp_convert_bufr_adpsfc ......................   Passed    3.65 sec
      Start 1901: test_gdasapp_convert_gsi_satbias
34/46 Test #1901: test_gdasapp_convert_gsi_satbias ......................   Passed    5.16 sec
      Start 1902: test_gdasapp_setup_atm_cycled_exp
35/46 Test #1902: test_gdasapp_setup_atm_cycled_exp .....................   Passed    1.02 sec
      Start 1903: test_gdasapp_atm_jjob_var_init
36/46 Test #1903: test_gdasapp_atm_jjob_var_init ........................   Passed   48.34 sec
      Start 1904: test_gdasapp_atm_jjob_var_run
37/46 Test #1904: test_gdasapp_atm_jjob_var_run .........................   Passed  203.01 sec
      Start 1905: test_gdasapp_atm_jjob_var_inc
38/46 Test #1905: test_gdasapp_atm_jjob_var_inc .........................   Passed  106.63 sec
      Start 1906: test_gdasapp_atm_jjob_var_final
39/46 Test #1906: test_gdasapp_atm_jjob_var_final .......................   Passed  106.37 sec
      Start 1907: test_gdasapp_atm_jjob_ens_init
40/46 Test #1907: test_gdasapp_atm_jjob_ens_init ........................   Passed   48.76 sec
      Start 1908: test_gdasapp_atm_jjob_ens_letkf
41/46 Test #1908: test_gdasapp_atm_jjob_ens_letkf .......................   Passed  490.72 sec
      Start 1909: test_gdasapp_atm_jjob_ens_obs
42/46 Test #1909: test_gdasapp_atm_jjob_ens_obs .........................   Passed   74.32 sec
      Start 1910: test_gdasapp_atm_jjob_ens_sol
43/46 Test #1910: test_gdasapp_atm_jjob_ens_sol .........................   Passed   42.81 sec
      Start 1911: test_gdasapp_atm_jjob_ens_inc
44/46 Test #1911: test_gdasapp_atm_jjob_ens_inc .........................   Passed  267.19 sec
      Start 1912: test_gdasapp_atm_jjob_ens_final
45/46 Test #1912: test_gdasapp_atm_jjob_ens_final .......................   Passed  106.36 sec
      Start 1913: test_gdasapp_aero_gen_3dvar_yaml
46/46 Test #1913: test_gdasapp_aero_gen_3dvar_yaml ......................   Passed    0.78 sec

100% tests passed, 0 tests failed out of 46

Label Time Summary:
gdas-utils    =  15.06 sec*proc (12 tests)
script        =  15.06 sec*proc (12 tests)

Total Test time (real) = 2702.64 sec

Hercules results

Test project /work/noaa/da/rtreadon/git/global-workflow/ensda_obs/sorc/gdas.cd/build
      Start 1532: test_gdasapp_util_coding_norms
 1/46 Test #1532: test_gdasapp_util_coding_norms ........................   Passed    2.72 sec
      Start 1533: test_gdasapp_util_ioda_example
 2/46 Test #1533: test_gdasapp_util_ioda_example ........................   Passed    4.98 sec
      Start 1534: test_gdasapp_util_prepdata
 3/46 Test #1534: test_gdasapp_util_prepdata ............................   Passed    1.25 sec
      Start 1535: test_gdasapp_util_rads2ioda
 4/46 Test #1535: test_gdasapp_util_rads2ioda ...........................   Passed    0.43 sec
      Start 1536: test_gdasapp_util_ghrsst2ioda
 5/46 Test #1536: test_gdasapp_util_ghrsst2ioda .........................   Passed    0.10 sec
      Start 1537: test_gdasapp_util_rtofstmp
 6/46 Test #1537: test_gdasapp_util_rtofstmp ............................   Passed    1.82 sec
      Start 1538: test_gdasapp_util_rtofssal
 7/46 Test #1538: test_gdasapp_util_rtofssal ............................   Passed    0.66 sec
      Start 1539: test_gdasapp_util_smap2ioda
 8/46 Test #1539: test_gdasapp_util_smap2ioda ...........................   Passed    0.11 sec
      Start 1540: test_gdasapp_util_smos2ioda
 9/46 Test #1540: test_gdasapp_util_smos2ioda ...........................   Passed    0.10 sec
      Start 1541: test_gdasapp_util_viirsaod2ioda
10/46 Test #1541: test_gdasapp_util_viirsaod2ioda .......................   Passed    0.09 sec
      Start 1542: test_gdasapp_util_icecamsr2ioda
11/46 Test #1542: test_gdasapp_util_icecamsr2ioda .......................   Passed    0.10 sec
      Start 1543: test_gdasapp_util_icecmirs2ioda
12/46 Test #1543: test_gdasapp_util_icecmirs2ioda .......................   Passed    0.10 sec
      Start 1881: test_gdasapp_check_python_norms
13/46 Test #1881: test_gdasapp_check_python_norms .......................   Passed    3.13 sec
      Start 1882: test_gdasapp_check_yaml_keys
14/46 Test #1882: test_gdasapp_check_yaml_keys ..........................   Passed    0.30 sec
      Start 1883: test_gdasapp_jedi_increment_to_fv3
15/46 Test #1883: test_gdasapp_jedi_increment_to_fv3 ....................   Passed    5.17 sec
      Start 1884: test_gdasapp_fv3jedi_fv3inc
16/46 Test #1884: test_gdasapp_fv3jedi_fv3inc ...........................   Passed   35.32 sec
      Start 1885: test_gdasapp_soca_nsst_increment_to_mom6
17/46 Test #1885: test_gdasapp_soca_nsst_increment_to_mom6 ..............   Passed   24.22 sec
      Start 1886: test_gdasapp_soca_prep
18/46 Test #1886: test_gdasapp_soca_prep ................................   Passed    3.14 sec
      Start 1887: test_gdasapp_soca_run_clean
19/46 Test #1887: test_gdasapp_soca_run_clean ...........................   Passed    0.22 sec
      Start 1888: test_gdasapp_soca_setup_obsprep
20/46 Test #1888: test_gdasapp_soca_setup_obsprep .......................   Passed   11.29 sec
      Start 1889: test_gdasapp_soca_JGLOBAL_PREP_OCEAN_OBS
21/46 Test #1889: test_gdasapp_soca_JGLOBAL_PREP_OCEAN_OBS ..............   Passed  330.86 sec
      Start 1890: test_gdasapp_soca_JGLOBAL_MARINE_BMAT
22/46 Test #1890: test_gdasapp_soca_JGLOBAL_MARINE_BMAT .................   Passed  330.25 sec
      Start 1891: test_gdasapp_soca_JGDAS_GLOBAL_OCEAN_ANALYSIS_PREP
23/46 Test #1891: test_gdasapp_soca_JGDAS_GLOBAL_OCEAN_ANALYSIS_PREP ....   Passed  234.23 sec
      Start 1892: test_gdasapp_soca_JGDAS_GLOBAL_OCEAN_ANALYSIS_RUN
24/46 Test #1892: test_gdasapp_soca_JGDAS_GLOBAL_OCEAN_ANALYSIS_RUN .....   Passed  298.25 sec
      Start 1893: test_gdasapp_soca_copy_scratch
25/46 Test #1893: test_gdasapp_soca_copy_scratch ........................   Passed    0.16 sec
      Start 1894: test_gdasapp_soca_JGDAS_GLOBAL_OCEAN_ANALYSIS_CHKPT
26/46 Test #1894: test_gdasapp_soca_JGDAS_GLOBAL_OCEAN_ANALYSIS_CHKPT ...   Passed  330.19 sec
      Start 1895: test_gdasapp_soca_JGDAS_GLOBAL_OCEAN_ANALYSIS_POST
27/46 Test #1895: test_gdasapp_soca_JGDAS_GLOBAL_OCEAN_ANALYSIS_POST ....   Passed  266.20 sec
      Start 1896: test_gdasapp_snow_create_ens
28/46 Test #1896: test_gdasapp_snow_create_ens ..........................   Passed    0.91 sec
      Start 1897: test_gdasapp_snow_imsproc
29/46 Test #1897: test_gdasapp_snow_imsproc .............................   Passed    3.55 sec
      Start 1898: test_gdasapp_snow_apply_jediincr
30/46 Test #1898: test_gdasapp_snow_apply_jediincr ......................   Passed    1.94 sec
      Start 1899: test_gdasapp_snow_letkfoi_snowda
31/46 Test #1899: test_gdasapp_snow_letkfoi_snowda ......................   Passed   37.78 sec
      Start 1900: test_gdasapp_convert_bufr_adpsfc_snow
32/46 Test #1900: test_gdasapp_convert_bufr_adpsfc_snow .................   Passed    2.41 sec
      Start 1901: test_gdasapp_convert_bufr_adpsfc
33/46 Test #1901: test_gdasapp_convert_bufr_adpsfc ......................   Passed    2.97 sec
      Start 1902: test_gdasapp_convert_gsi_satbias
34/46 Test #1902: test_gdasapp_convert_gsi_satbias ......................   Passed    4.35 sec
      Start 1903: test_gdasapp_setup_atm_cycled_exp
35/46 Test #1903: test_gdasapp_setup_atm_cycled_exp .....................   Passed    0.62 sec
      Start 1904: test_gdasapp_atm_jjob_var_init
36/46 Test #1904: test_gdasapp_atm_jjob_var_init ........................   Passed   76.25 sec
      Start 1905: test_gdasapp_atm_jjob_var_run
37/46 Test #1905: test_gdasapp_atm_jjob_var_run .........................   Passed  138.16 sec
      Start 1906: test_gdasapp_atm_jjob_var_inc
38/46 Test #1906: test_gdasapp_atm_jjob_var_inc .........................   Passed   74.16 sec
      Start 1907: test_gdasapp_atm_jjob_var_final
39/46 Test #1907: test_gdasapp_atm_jjob_var_final .......................   Passed   42.16 sec
      Start 1908: test_gdasapp_atm_jjob_ens_init
40/46 Test #1908: test_gdasapp_atm_jjob_ens_init ........................   Passed   44.17 sec
      Start 1909: test_gdasapp_atm_jjob_ens_letkf
41/46 Test #1909: test_gdasapp_atm_jjob_ens_letkf .......................   Passed  522.20 sec
      Start 1910: test_gdasapp_atm_jjob_ens_obs
42/46 Test #1910: test_gdasapp_atm_jjob_ens_obs .........................   Passed  106.16 sec
      Start 1911: test_gdasapp_atm_jjob_ens_sol
43/46 Test #1911: test_gdasapp_atm_jjob_ens_sol .........................   Passed   42.14 sec
      Start 1912: test_gdasapp_atm_jjob_ens_inc
44/46 Test #1912: test_gdasapp_atm_jjob_ens_inc .........................   Passed  106.15 sec
      Start 1913: test_gdasapp_atm_jjob_ens_final
45/46 Test #1913: test_gdasapp_atm_jjob_ens_final .......................   Passed   42.16 sec
      Start 1914: test_gdasapp_aero_gen_3dvar_yaml
46/46 Test #1914: test_gdasapp_aero_gen_3dvar_yaml ......................   Passed    0.36 sec

100% tests passed, 0 tests failed out of 46

Label Time Summary:
gdas-utils    =  12.46 sec*proc (12 tests)
script        =  12.46 sec*proc (12 tests)

Total Test time (real) = 3138.08 sec

@RussTreadon-NOAA
Copy link
Contributor Author

The changes in this PR are now ready for review. This PR must be approved and merge into GDASApp develop before g-w PR #2833 can be marked Ready_for_review.

@TravisElless-NOAA and @CoryMartin-NOAA - do either of you have time to look over these changes?

@CoryMartin-NOAA
Copy link
Contributor

Yes @RussTreadon-NOAA I'll look at it today. Especially since I think it contains a fix I need for my 2 g-w PRs to pass CI

@TravisElless-NOAA
Copy link

Yep, I'll take a look this afternoon.

@RussTreadon-NOAA
Copy link
Contributor Author

Thank you @CoryMartin-NOAA and @TravisElless-NOAA . Any other recommended reviewers?

Copy link

@TravisElless-NOAA TravisElless-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All the ensemble related changes look good to me. Thanks @RussTreadon-NOAA!

@CoryMartin-NOAA CoryMartin-NOAA merged commit 0431b26 into NOAA-EMC:develop Aug 20, 2024
5 checks passed
@RussTreadon-NOAA
Copy link
Contributor Author

Thank you @CoryMartin-NOAA and @TravisElless-NOAA!

Next stop: g-w PR #2833.

@RussTreadon-NOAA RussTreadon-NOAA deleted the feature/ensda_obs branch August 21, 2024 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update jcb templates for local ensemble observer and solver jobs
3 participants