-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add lgetkf observer and solver templates #1252
add lgetkf observer and solver templates #1252
Conversation
…with jcb template (NOAA-EMC#1249)
Hera ctests Install GDASApp
|
Hercules ctests Install GDASApp
|
This PR is ready for review. This PR must be approved and merged into GDASApp |
Realize that I should add letkf observer and solver ctests to |
Hera and Hercules ctests Hera results
Hercules results
|
The changes in this PR are now ready for review. This PR must be approved and merge into GDASApp @TravisElless-NOAA and @CoryMartin-NOAA - do either of you have time to look over these changes? |
Yes @RussTreadon-NOAA I'll look at it today. Especially since I think it contains a fix I need for my 2 g-w PRs to pass CI |
Yep, I'll take a look this afternoon. |
Thank you @CoryMartin-NOAA and @TravisElless-NOAA . Any other recommended reviewers? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All the ensemble related changes look good to me. Thanks @RussTreadon-NOAA!
Thank you @CoryMartin-NOAA and @TravisElless-NOAA! Next stop: g-w PR #2833. |
This PR adds prototype templates to run the lgetkf in observation and solver modes. Doing so necessitates updates to
parm/jcb-algorithms
andparm/jcb-gdas
.The PR also changes the
iodafile
inush/ioda/bufr2ioda/bufr2ioda_acft_profiles_prepbufr.py
to be consistent with thejcb-gdas
template.Resolves #1249
Dependencies
DO NOT MERGE THIS PR into GDASApp
develop
untildevelop