Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update resdet and resens keywords in prototypes #867

Merged

Conversation

RussTreadon-NOAA
Copy link
Contributor

This PR replaces --resdet and --resens with --resdetatmos and --resensatmos, respectively, in order to restore the functionality of automated GDASApp tests which exercise g-w.

Resolves #866

@RussTreadon-NOAA RussTreadon-NOAA self-assigned this Jan 23, 2024
@RussTreadon-NOAA RussTreadon-NOAA added hera-RT Queue for automated testing on Hera orion-RT Queue for automated testing on Orion labels Jan 23, 2024
@emcbot emcbot added hera-RT-Running Automated testing running on Hera orion-RT-Running Automated testing running on Orion and removed hera-RT Queue for automated testing on Hera orion-RT Queue for automated testing on Orion labels Jan 23, 2024
@emcbot
Copy link

emcbot commented Jan 23, 2024

Automated GDASApp Testing Results:
Machine: orion

Start: Tue Jan 23 08:02:44 CST 2024 on Orion-login-1.HPC.MsState.Edu
---------------------------------------------------
Build:                                 *SUCCESS*
Build: Completed at Tue Jan 23 08:49:45 CST 2024
---------------------------------------------------
Tests:                                 *SUCCESS*
Tests: Completed at Tue Jan 23 08:55:01 CST 2024
Tests: 100% tests passed, 0 tests failed out of 30

@emcbot emcbot added orion-RT-Passed Automated testing successful on Orion and removed orion-RT-Running Automated testing running on Orion labels Jan 23, 2024
@emcbot
Copy link

emcbot commented Jan 23, 2024

Automated GDASApp Testing Results:
Machine: hera

Start: Tue Jan 23 14:05:28 UTC 2024 on hfe10
---------------------------------------------------
Build:                                 *SUCCESS*
Build: Completed at Tue Jan 23 14:57:46 UTC 2024
---------------------------------------------------
Tests:                                 *SUCCESS*
Tests: Completed at Tue Jan 23 14:58:51 UTC 2024
Tests: 100% tests passed, 0 tests failed out of 30

@emcbot emcbot added hera-RT-Passed Automated testing successful on Hera and removed hera-RT-Running Automated testing running on Hera labels Jan 23, 2024
@RussTreadon-NOAA RussTreadon-NOAA added hera-GW-RT Queue for automated testing with global-workflow on Hera orion-GW-RT Queue for automated testing with global-workflow on Orion labels Jan 23, 2024
Copy link
Contributor

@CoryMartin-NOAA CoryMartin-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved pending CI tests pass

@emcbot emcbot added orion-GW-RT-Running Automated testing with global-workflow running on Orion hera-GW-RT-Running Automated testing with global-workflow running on Hera and removed orion-GW-RT Queue for automated testing with global-workflow on Orion hera-GW-RT Queue for automated testing with global-workflow on Hera labels Jan 23, 2024
@emcbot
Copy link

emcbot commented Jan 23, 2024

Automated Global-Workflow GDASApp Testing Results:
Machine: orion

Start: Tue Jan 23 09:19:57 CST 2024 on Orion-login-1.HPC.MsState.Edu
---------------------------------------------------
Build:                                 *SUCCESS*
Build: Completed at Tue Jan 23 10:11:39 CST 2024
---------------------------------------------------
Tests:                                 *SUCCESS*
Tests: Completed at Tue Jan 23 11:20:22 CST 2024
Tests: 100% tests passed, 0 tests failed out of 52

@emcbot emcbot added orion-GW-RT-Passed Automated testing with global-workflow successful on Orion and removed orion-GW-RT-Running Automated testing with global-workflow running on Orion labels Jan 23, 2024
@emcbot
Copy link

emcbot commented Jan 23, 2024

Automated Global-Workflow GDASApp Testing Results:
Machine: hera

Start: Tue Jan 23 15:27:57 UTC 2024 on hfe07
---------------------------------------------------
Build:                                 *SUCCESS*
Build: Completed at Tue Jan 23 16:13:03 UTC 2024
---------------------------------------------------
Tests:                                  *Failed*
Tests: Failed at Tue Jan 23 17:31:12 UTC 2024
Tests: 96% tests passed, 2 tests failed out of 52
	1721 - test_gdasapp_atm_jjob_ens_final (Failed)
Tests: see output at /scratch1/NCEPDEV/da/Cory.R.Martin/CI/GDASApp/workflow/PR/867/global-workflow/sorc/gdas.cd/build/log.ctest

@emcbot emcbot added hera-GW-RT-Failed Automated testing with global-workflow failed on Hera and removed hera-GW-RT-Running Automated testing with global-workflow running on Hera labels Jan 23, 2024
@RussTreadon-NOAA
Copy link
Contributor Author

test_gdasapp_atm_jjob_ens_final failed because test_gdasapp_atm_jjob_ens_run (jobid 54715722) is still waiting in the queue. After 30 minutes, ctest flagged test_gdasapp_atm_jjob_ens_run as Timeout and moved onto ens_final

49/52 Test #1719: test_gdasapp_atm_jjob_ens_init ........................   Passed   75.46 sec
      Start 1720: test_gdasapp_atm_jjob_ens_run
50/52 Test #1720: test_gdasapp_atm_jjob_ens_run .........................***Timeout 1500.39 sec

...

+ sbatch --nodes=1 --ntasks=36 --account=da-cpu --qos=batch --time=00:30:00 --export=ALL --wait /scratch1/NCEPDEV/da/Cory.R.Martin/CI/GDASApp/workflow/PR/867/global-workflow/jobs/JGLOBAL_ATMENS_ANALYSIS_RUN
Submitted batch job 54715722

      Start 1721: test_gdasapp_atm_jjob_ens_final
51/52 Test #1721: test_gdasapp_atm_jjob_ens_final .......................***Failed   42.16 sec

Job ens_final failed because expected output from ens_run was not present.

@RussTreadon-NOAA
Copy link
Contributor Author

@CoryMartin-NOAA , would you like me to trigger hera-GW-RT again or is the explanation above sufficient?

@CoryMartin-NOAA
Copy link
Contributor

Good enough for me, I'll click merge.

@CoryMartin-NOAA CoryMartin-NOAA merged commit 839e8a2 into NOAA-EMC:develop Jan 23, 2024
26 checks passed
@RussTreadon-NOAA RussTreadon-NOAA deleted the feature/prototypes branch January 31, 2024 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hera-GW-RT-Failed Automated testing with global-workflow failed on Hera hera-RT-Passed Automated testing successful on Hera orion-GW-RT-Passed Automated testing with global-workflow successful on Orion orion-RT-Passed Automated testing successful on Orion
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update resolution keywords in automated GDASApp workflow
3 participants