Update dev/emc from gsd/develop 2020/06/30 #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…climbfuji/GFDL_atmos_cubed_sphere into update_master_from_gsl_develop_20200630
This was referenced Jun 30, 2020
|
@bensonr Can you please have a look and approve this PR? It's an obvious bug fix solves a lot of crashes EMC and GSL developers have seen since the fv3 dycore commit a few weeks back. Thanks very much! |
bensonr
reviewed
Jul 1, 2020
climbfuji
force-pushed
the
update_master_from_gsl_develop_20200630
branch
from
819f118 to
8ca6f50
Compare
bensonr
approved these changes
Jul 1, 2020
|
Thanks, @bensonr ! |
DusanJovic-NOAA
approved these changes
Jul 2, 2020
This was referenced Jul 2, 2020
tsupinie
pushed a commit
to tsupinie/GFDL_atmos_cubed_sphere
that referenced
this pull request
Jul 20, 2020
* Bugfix in tools/fv_diagnostics.F90: correct dimensions of delz in several routines
tsupinie
pushed a commit
to tsupinie/GFDL_atmos_cubed_sphere
that referenced
this pull request
Jul 20, 2020
* Bugfix in tools/fv_diagnostics.F90: correct dimensions of delz in several routines
aerorahul
pushed a commit
that referenced
this pull request
Jul 17, 2021
Fixes gnu compile issues with fv_diagnostics.F90
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes in this PR:
delzas in PR Correct dimensions of delz in two diagnostic routines #27 (the latter can be closed after this PR has been merged)Users at GSL have reported that after merging this bugfix, the model crashes they have seen after the dycore was updated went away.
Associated PRs:
NCAR/ccpp-physics#465
NCAR/ccpp-framework#307
#30
NOAA-EMC/fv3atm#134
ufs-community/ufs-weather-model#156
For regression testing information, see ufs-community/ufs-weather-model#156.