Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/gwdev issue 2329 #127

Merged
merged 3 commits into from
Mar 22, 2024
Merged

Feature/gwdev issue 2329 #127

merged 3 commits into from
Mar 22, 2024

Conversation

HenryRWinterbottom
Copy link
Contributor

This PR adds support for the RDHPCS Rocky-8 upgrade.

Related issue: #2329

aerorahul
aerorahul approved these changes Mar 20, 2024
View reviewed changes
Copy link
Contributor

@aerorahul aerorahul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good.

DavidHuber-NOAA
DavidHuber-NOAA approved these changes Mar 20, 2024
View reviewed changes
Copy link
Collaborator

@DavidHuber-NOAA DavidHuber-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tested the ozone and radiance monitors in a global-workflow test. The minimization monitor needs a Perl module (Lists/MoreUtils) in order to be testable from the workflow. Since that module is only required for the global workflow: approve.

EdwardSafford-NOAA
EdwardSafford-NOAA approved these changes Mar 20, 2024
View reviewed changes
Copy link
Collaborator

@EdwardSafford-NOAA EdwardSafford-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good by me.

@DavidHuber-NOAA
Copy link
Collaborator

The Hera GNU module file should also be updated.

@aerorahul aerorahul merged commit 3ecfe07 into NOAA-EMC:develop Mar 22, 2024
4 checks passed
@aerorahul aerorahul mentioned this pull request Apr 26, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DavidHuber-NOAA DavidHuber-NOAA DavidHuber-NOAA approved these changes

@EdwardSafford-NOAA EdwardSafford-NOAA EdwardSafford-NOAA approved these changes

@aerorahul aerorahul aerorahul approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@HenryRWinterbottom @DavidHuber-NOAA @aerorahul @EdwardSafford-NOAA @henrywinterbottom-wxdev