Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add safeguards to getsigensmeanp_smooth and recentersigp #40

Closed
RussTreadon-NOAA opened this issue May 14, 2024 · 1 comment · Fixed by #41
Closed

add safeguards to getsigensmeanp_smooth and recentersigp #40

RussTreadon-NOAA opened this issue May 14, 2024 · 1 comment · Fixed by #41
Assignees
@RussTreadon-NOAA

Comments

@RussTreadon-NOAA
Copy link
Contributor

getsigensmeanp_smooth.x and recentersigp.x failures in g-w PR #2592 highlight the need to update each code with the following good coding practices

  • initialize variables before use
  • check allocate status before deallocating
  • check the correct error return codes from subroutines

This PR is opened to enhance getsigensmeanp_smooth_ncep.f90 and recentersigp.f90 by incorporating the above coding practices into select sections of each source code file.
@RussTreadon-NOAA RussTreadon-NOAA self-assigned this May 14, 2024
@RussTreadon-NOAA
Copy link
Contributor Author

Work for this issue will be done in feature/safeguard.

RussTreadon-NOAA added a commit that referenced this issue May 14, 2024
@RussTreadon-NOAA
enhance safeguards in getsigensmeanp_smooth and recentersigp (#40)
4e227d8
@RussTreadon-NOAA RussTreadon-NOAA mentioned this issue May 14, 2024
Merged
RussTreadon-NOAA added a commit that referenced this issue May 14, 2024
@RussTreadon-NOAA
remove unnecessary declaration of iargc (#40)
0309845
RussTreadon-NOAA added a commit that referenced this issue May 15, 2024
@RussTreadon-NOAA
add field width for formated output (#40)
9208b5f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@RussTreadon-NOAA RussTreadon-NOAA

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

enhance safeguards in getsigensmeanp_smooth and recentersigp NOAA-EMC/GSI-utils
1 participant
@RussTreadon-NOAA