-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade modules to spack-stack/1.5.1 on non-production machines. #19
Upgrade modules to spack-stack/1.5.1 on non-production machines. #19
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have no CI testing for GSI-utils. This is problematic.
@DavidHuber-NOAA tested the updated GSI-utils in g-w on Hera and Orion. The build was tested on WCOSS2 (along with other machines). Since Dave did not report any anomalies, I assume GSI-utils behaves acceptably when built from spack-stack/1.5.1.
`src/netcdf_io/interp_inc.fd/driver.F90 was updated. The change is related to ip. An ip-lib subject matter expert could check this update if we want confirmation that the change is OK.
@RussTreadon-NOAA I am working on updating the CI for gsi-utils for this PR. I will submit it shortly. |
Hmm, for some reason, |
@aerorahul I'm not sure how to get |
can you install |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Thanks for updating the CI, updating the utilities to newer versions of the libraries and porting to spack-stack.
@souopgui-redline identified a bug causing a hang on S4. The netcdf file read in |
This also worked on Orion. I think this is now ready to merge once CI tests complete. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Trust your testing @DavidHuber-NOAA and trust @aerorahul 's review.
Approve.
All CI tests passed. I don't think there are any further hurdles and that this is ready to merge. |
This upgrades the modules on non-productions machines to use the local spack-stack installations. This has been build-tested on Hera (Intel and GNU), Orion, S4, Jet, and WCOSS2. It has been run-tested on Orion and Hera within global workflow experiments.
In the process, the Cheyenne modulefiles have been removed as that system is being decomissioned and spack-stack/1.5.1 is not available there.
Resolves #18