You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In the RRFS workflow, after the anal_gsi_input task runs, the specific humidity field ("sphum") in the fv_tracer INPUT NetCDF file contains negative values. After hybrid_radar_ref GSI runs, there are also negative values in the hydrometeors ice_wat, liq_wat, rainwat, snowwat, and graupel. None of these variables can physically be negative.
The text was updated successfully, but these errors were encountered:
)
**Description**
Clips negative values from fields in the tracer file before writing.
Fixes#680.
**Type of change**
- [ ] Bug fix (non-breaking change which fixes an issue)
**How Has This Been Tested?**
Tested on Hera in a RRFS CONUS workflow with both hybrid_radar_ref and
anal_gsi_input tasks.
See run directory at /scratch2/BMC/zrtrr/aback/hydrometeors_test/
For one hour of the control run without this change, and one hour using
the change contained in this PR, the INPUT directory was saved for
reference/rerunning before each of the tasks: anal_gsi_input_spinup,
hybrid_radar_ref_spinup, cldanl_nonvar_spinup, and run_fcst spinup.
Those directories are at, for example
/scratch2/BMC/zrtrr/aback/hydrometeors_test/INPUT_after_anal_gsi_input_spinup_before_hybrid_radar_ref_spinup
("control") and
/scratch2/BMC/zrtrr/aback/hydrometeors_test/clipped_INPUT_after_anal_gsi_input_spinup_before_hybrid_radar_ref_spinup
(using the code in the PR).
Logs are at
/scratch2/BMC/zrtrr/aback/hydrometeors_test/v0.7.9/logs/rrfs.20230610/08/,
including new logs produced between all the above-listed tasks, showing
all the min and max values in fv_tracer.
**Checklist**
The code is Ting Lei's. It looks stylish and understandable to me
(Amanda) but maybe Ting should weigh in on this section.
- [ ] My code follows the style guidelines of this project
- [ ] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] New and existing tests pass with my changes
- [ ] Any dependent changes have been merged and published
**DUE DATE for merger of this PR into `develop` is 2/22/2024 (six weeks
after PR creation).**
---------
Co-authored-by: Ting.Lei-NOAA <ting.lei@dlogin09.dogwood.wcoss2.ncep.noaa.gov>
In the RRFS workflow, after the anal_gsi_input task runs, the specific humidity field ("sphum") in the fv_tracer INPUT NetCDF file contains negative values. After hybrid_radar_ref GSI runs, there are also negative values in the hydrometeors ice_wat, liq_wat, rainwat, snowwat, and graupel. None of these variables can physically be negative.
The text was updated successfully, but these errors were encountered: