call_crtm bug fix for gmi #109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is issue #68 associated with this work? If it isn't, please create a new issue for this bug fix. Also, who would you like to have review your bug fix? All work requires third party review before being merged to the master. Thanks, Mike |
Closed
|
The fix for stability looks good, but should we make similar modifications for other optional variables as well, such as hwp_ratio, tcwv? |
|
suggest to modify the line 2073 to be present(hwp_ratio) hwp_ratio = hwp_guess(1)/(hwp_guess(1)+hwp_guess(2)) and the line 2033 to be present (tcwv) tcwv = tcwv + (atmosphere(1)%absorber(k,1)*0.001_r_kind)*c6(k) |
|
The due date for the review committee has past with no feedback, so I will give this fix final approval and merge it into the NOAA-EMC/GSI master. |
ilianagenkova
added a commit
to ilianagenkova/GSI
that referenced
this pull request
Jan 25, 2022
…op-BC and Him-8 new BUFR, station_id bug fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In line 933 in setuprad.f90, the function call_crtm is called without the optional parameter 'stability'. The function call_crtm has been assigning a value to stability without checking if it is present. This fixes this bug.