GSI Issue #233: Fix indexing issues in correlated error #236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ADCollard
approved these changes
Oct 18, 2021
RussTreadon-NOAA
approved these changes
Oct 18, 2021
There was a problem hiding this comment.
As documented in #233, these changes allow the global_gsi.x to run to completion when using the gfs (early dump) configuration. Absent these changes, the global_gsi.x seg faults. When accounting for genqsat.f90 differences, gdas (late dump) tests of the fork and authoritative gfsda.v16.x generate identical results. As such, the changes in this PR should be merged into the authoritative gfsda.v16.x.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR brings the source code and utility changes for the correlated obs error from @KristenBathmann into release/gfsda.v16.x. The associated fix files have been brought into the release branch by 2c8b219.
See #233 for details.