Rahulproblem #315
Rahulproblem #315
Conversation
…FV3 DA (FV3LAMDA)
There was a problem hiding this comment.
I have completed my visual inspection of the code changes. There is an issue with HDRAOB on line 228. Please add the initial ' to the character string. Also, please use the following steps to remove the changes to fix, regression/regression_var.sh, and reduce the number of commits to a single commit (please note that a new PR will need to be created after following the steps):
- git clone --recursive git@github.com:jderber-NOAA/GSI.git update
- cd update
- git checkout rahulproblem
- git remote add upstream git@github.com:NOAA-EMC/GSI.git
- git remote update
- git checkout upstream/master
- git checkout -b hf/rahulproblem
- git submodule update
- git merge --squash rahulproblem
- git reset HEAD fix regression/regression_var.sh
- git checkout -- regression/regression_var.sh
- Make necessary change to line 228 in src/gsi/hdraobmod.f90
- git add src/gsi/hdraobmod.f90
git commit -m "GitHub Issue NOAA-EMC/GSI#314. Modify hdraobmod.f90 to fix problem with GNU compiler found by Rahul."- git push origin hf/rahulproblem
- Create a new PR using this hotfix branch
These steps will reduce the 11 commits to a single commit, remove the regression of the fix submodule from 2ff8065 to f5bdc1, correct the issue in hdraobmod.f90 that is keeping the GSI from compiling on WCOSS, and undo the change to regression/regression_var.sh. There is no need to remove the current PR, since Rahul and I have already completed our review of the correction.
If you have any questions, please let me know.
| @@ -220,6 +224,8 @@ subroutine read_hdraob(nread,ndata,nodata,infile,obstype,lunout,twindin,sis,& | |||
|
|
|||
| print_verbose=.false. | |||
| if(verbose) print_verbose=.true. | |||
| c_prvstg = '88888888' | |||
| c_sprvstg =HDRAOB' | |||
There was a problem hiding this comment.
Please include the ' before HDRAOB' on line 228. The code fails to compile with the following:
/gpfs/dell2/emc/modeling/noscrub/Michael.Lueken/update/src/gsi/hdraobmod.f90(228): error #5120: Unterminated character constant
c_sprvstg =HDRAOB'
-------------------^
Rahul reports hdraobmod does not compile with GNU compiler. Minor changes are made to make it compile.