Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub Issue NOAA-EMC/GSI#318. Remove ush/EnKF directory with obsolete scripts #319

Merged
merged 1 commit into from
Mar 2, 2022
Merged

GitHub Issue NOAA-EMC/GSI#318. Remove ush/EnKF directory with obsolete scripts #319

merged 1 commit into from
Mar 2, 2022

Conversation

aerorahul
Copy link
Contributor

This PR removes an outdated and obsolete directory ush/EnKF.
This directory used to contain scripts for standalone GSI and EnKF that were used at some point in time.
They have since been out of sync and likely won't work without major undertaking.

Closes #318

@MichaelLueken
Copy link
Contributor

@aerorahul I'm fine with moving forward with the removal of obsolete scripts in ush/EnKF. Before I merge this PR to the authoritative repository, please amend your commit message so that it is in line with the guidance in the wiki:

  • git commit --amend
  • Add GitHub Issue NOAA-EMC/GSI#318 to the commit message
  • Save and close out of the commit message window
  • git push origin feature/remove-deprecated --force

@aerorahul
Copy link
Contributor Author

  • origin feature/remove-deprecated --force

done.

@MichaelLueken MichaelLueken changed the title remove ush/EnKF directory with obsolete scripts GitHub Issue NOAA-EMC/GSI#318. Remove ush/EnKF directory with obsolete scripts Mar 2, 2022
@MichaelLueken
Copy link
Contributor

Thank you very much @aerorahul! Since there are no changes to the source code, I will now give final approval to this update and merge it to the authoritative repository.

@MichaelLueken MichaelLueken merged commit 828c0cf into NOAA-EMC:master Mar 2, 2022
@aerorahul aerorahul deleted the feature/remove-deprecated branch March 3, 2022 19:08
AndrewEichmann-NOAA pushed a commit to AndrewEichmann-NOAA/GSI that referenced this pull request Jun 6, 2022
GitHub Issue NOAA-EMC#318. Remove ush/EnKF directory with obsolete scripts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Removal of scripts under ush/EnKF/
2 participants