GitHub Issue NOAA-EMC/GSI#310 and #367. Correct RadMon's mean correction time series plots and update html generation. #366

EdwardSafford-NOAA · 2022-04-25T18:08:36Z

Fix the mean correction plots in the RadMon, which often displayed all 0 values for the sdv.

This issue was traced back to the numerical format used in the files sent to the server. The format did not include enough digits beyond the decimal point and often resulted in rounding to 0.

Note that this improves the situation but more work needs to be done. In the resulting plots the mouse-over values in the sdv plots, even when indicated they are non-zero, are still rounding to 0 in the mouse-over value display. It may be possible to improve the javascript formatting of the data values. It also may be that reverting to static plots might be a more satisfactory solution, though the ability to compare values on the fly would be lost.

@MichaelLueken-NOAA this change is trivial enough that I don't think a code review, beyond your once-over, is necessary.

MichaelLueken · 2022-04-26T12:49:43Z

Hi @EdwardSafford-NOAA. This PR has four commits. To reduce the number of commits:

git clone --recursive git@github.com:EdwardSafford-NOAA/GSI.git update
cd update
git reset --hard HEAD~1
git reset --hard HEAD~1
git reset --hard HEAD~1
git reset --hard HEAD~1
git remote add upstream https://github.com/NOAA-EMC/GSI.git
git remote update
git rebase upstream/develop
git submodule update
git checkout RadMon_310
git checkout develop
git merge --squash RadMon_310
git commit -m "Github issue #310. Correct mean correction time series plots. Fixes #310."
git push origin develop --force

This will reduce the four commits to a single commit. This change should be merged to the authoritative develop branch next Tuesday (when the last of the GFS v16.x updates will be merged to develop).

If you have any questions, please let me know.

EdwardSafford-NOAA · 2022-04-26T13:19:26Z

@MichaelLueken-NOAA I must have messed something up. Now I have 5 commits instead of 4. My guess is I messed up the transition from master to develop. I did have problems quite a bit of a struggle with that, but thought I had it worked out.

MichaelLueken · 2022-04-26T14:10:12Z

@EdwardSafford-NOAA. What types of issues did you encounter while going through the previous steps? It looks like you might have used git pull after following the original steps. Please try:

git clone --recursive git@github.com:EdwardSafford-NOAA/GSI.git test
cd test
git reset --hard HEAD~1
git checkout RadMon_310
git checkout develop
git merge --squash RadMon_310
git commit -m "Github issue #310. Correct mean correction time series plots. Fixes #310."

At this point, I have:

[Michael.Lueken@v71a2 test]$ git status
On branch develop
Your branch and 'origin/develop' have diverged,
and have 1 and 5 different commits each, respectively.
  (use "git pull" to merge the remote branch into yours)

Please don't use the recommended git pull command. This will add back in the removed commit messages and add another commit message as well. Instead, please use:

git push origin develop --force

to push the change back to the repository.

EdwardSafford-NOAA · 2022-04-26T14:40:28Z

@MichaelLueken-NOAA Thanks for your continued patience. I think it's ok now.

MichaelLueken · 2022-04-26T15:11:45Z

@EdwardSafford-NOAA Yep, everything looks good. I should be able to merge this next Tuesday after the current work out to the review committee is merged. Thank you very much for doing this!

EdwardSafford-NOAA · 2022-04-29T13:37:43Z

@MichaelLueken-NOAA I have to offer apologies again for my incompetence. I squash merged my 2nd dev branch, RadMon_367, into my develop branch and committed it with --amend and --no-edit, but I still managed to add 4 commits instead of just the one. I have no idea how I messed up but I sure did. Sorry for creating more work for you. I'll be glad to fix it if you tell me how.

MichaelLueken · 2022-04-29T14:04:53Z

@EdwardSafford-NOAA No worries. Please try the following:

git clone --recursive git@github.com:EdwardSafford-NOAA/GSI.git test
cd test
git reset --hard HEAD~1
git reset --hard HEAD~1
git reset --hard HEAD~1
git reset --hard HEAD~1
git remote add upstream https://github.com/NOAA-EMC/GSI.git
git remote update
git rebase upstream/develop
git submodule update
git checkout RadMon_310
git checkout develop
git merge --squash RadMon_310
git commit -m "Github issue #310. Correct mean correction time series plots. Fixes #310."
git checkout RadMon_367
git checkout develop
git merge --squash RadMon_367
git commit --amend
git push origin develop --force

These steps should allow you clone get both issue #310 and #367 changes into your fork's develop branch with only a single commit message.

EdwardSafford-NOAA · 2022-04-29T14:41:21Z

@MichaelLueken-NOAA thanks as always for your help. I think it's ok now.

MichaelLueken · 2022-04-29T14:45:05Z

@EdwardSafford-NOAA Yep, everything looks good now. I have also added issue #367 to the list of issues that can be closed with this PR. Is there anyone you would like to have review the html changes, or should that not be required?

EdwardSafford-NOAA · 2022-04-29T14:49:42Z

@MichaelLueken-NOAA a review isn't essential; these changes are in the non-operational portion of the package and are not routinely used. If @DavidHuber-NOAA is free I'd welcome his $0.02, but I wouldn't hold up release if he's not able to look it over.

DavidHuber-NOAA

Looks good to me. Thanks!

MichaelLueken · 2022-05-02T13:55:36Z

@EdwardSafford-NOAA Please use the following commands to reduce the 2 commits to a single commit:

git clone --recursive git@github.com:EdwardSafford-NOAA/GSI.git update
cd update
git reset --hard HEAD~1
git remote add upstream https://github.com/NOAA-EMC/GSI.git
git remote update
git rebase upstream/develop
git push origin develop --force

Thanks!

…ixes NOAA-EMC#310.

EdwardSafford-NOAA · 2022-05-02T14:04:39Z

@MichaelLueken-NOAA sorry, I got ahead of things and updated my develop branch from upstream, forgetting that would mess up this PR.

MichaelLueken · 2022-05-03T13:46:28Z

Since there are no source code changes and @DavidHuber-NOAA has reviewed the changes, will now give final approval to these changes and merge them to the authoritative repository.

aerorahul · 2022-05-10T03:20:14Z

Why was a tarball sum_thumbs.tar with thumbnail sized pngs included in this PR?

EdwardSafford-NOAA · 2022-05-10T11:06:07Z

The pngs are used by the RadMon's website building script on the splash page. I guess the thumbs could be left on the server and manipulated remotely, but it made sense to me to put all the RadMon html related files in one place. Also, from what I've heard there is no backup for emcrzdm, so a copy might be useful.

aerorahul · 2022-05-11T13:38:43Z

The pngs are used by the RadMon's website building script on the splash page. I guess the thumbs could be left on the server and manipulated remotely, but it made sense to me to put all the RadMon html related files in one place. Also, from what I've heard there is no backup for emcrzdm, so a copy might be useful.

Generally speaking, committing binary files to a git repository is not recommended.
This is so because Git cannot diff a binary file. It will upload the entire file into the repository and will store it as is forever.
If there is going to be an update to the binary file, Git will upload another copy (rather than the diff), thereby increasing the size of the git repository.
When this repository is cloned, the clone will download every single version of the binary file; thus slowing down the clone.

NOAA-EMC does not pay for Git-LFS (a solution for storing binary files in Git on GitHub).

Having said that, if the thumbs will never be updated (.tar), then I think this will likely not be a concern.
I suspect, new thumbs will be added as new instruments get added, and thus this tar ball will be replaced with another one.

EdwardSafford-NOAA · 2022-05-11T13:52:57Z

@aerorahul Thanks for the detailed explanation. I wasn't aware of the git issues with binary files.

Yes, your sense is right -- the thumbs will change over time in response to changes in available instruments. I'll make a point of replacing the file as needed rather than updating it.

aerorahul · 2022-05-11T14:03:29Z

@EdwardSafford-NOAA replacing the file is the same as adding new file. The history will still contain the old file and a new file. I don't think that changes anything.
If you have:

thumbA.png
thumbB.png
thumbC.png

and then you add

thumbD.png

then I think we can live with it.

But, if you replace thumbA.png with a newer version (copy) of thumbA.png, then the repo still stores 2 copies of thumbA.png; the original and the new.
If you are certain that once the thumbs are added, they won't be updated, then we can possibly live with it.
To do so this way, you will need to remove the tar and store the pngs as individual files in a png directory.

EdwardSafford-NOAA · 2022-05-11T14:26:27Z

@aerorahul The individual thumbs will never be updated -- there isn't any need for that. I'll open a new issue to remove the tar and move the thumbs to a new png directory.

aerorahul · 2022-05-11T14:31:25Z

@EdwardSafford-NOAA
Removing of binary files from history is a bit more involved.
Just removing the files do not remove it from the history.
Also, any branch that now have since been created after this went to develop now contain these binary files.

EdwardSafford-NOAA · 2022-05-11T14:43:00Z

@aerorahul Sorry, I had no idea the scope of this problem. I'll investigate how to remove the binaries from history.

EdwardSafford-NOAA · 2022-05-11T20:16:04Z

@aerorahul I read there are some tools that will assist with rewriting history but I assume they are not available. I tested this solution locally:

git filter-branch --index-filter "git rm -rf --cached --ignore-unmatch util/Radiance_Monitor/image_gen/html/sum_thumbs.tar" HEAD~5..HEAD

That seems to work -- the file is removed and the last 5 commits are modified to remove all references to the tar file. I assume that @MichaelLueken-NOAA would need to run this on the authoritative develop branch in order to really implement it. As for branches created from develop since the merger (f16e852), I'm not yet sure how best to handle that.

aerorahul · 2022-05-11T20:32:24Z

@EdwardSafford-NOAA
Excellent. Thanks for the research on this.

I think any branch created since the merge will have to do the same on the branch on the users fork.

I am not sure about this next bit, but I think the develop branch on the users fork will also need to get a force push to remove the references to the binary files. Or possibly, the user might have to fork again. I am not sure about this bit, but I am certain something needs to be done with the develop branch that contains the traces of this file on the users fork.

But, as you can see, once a binary file gets in, it gets very difficult to get rid of its traces, especially when there is a large community involved.

EdwardSafford-NOAA · 2022-05-12T18:27:50Z

@aerorahul

But, as you can see, once a binary file gets in, it gets very difficult to get rid of its traces, especially when there is a large community involved.

That is very clear now. I am really sorry my ignorance resulted in this mess.

I explored interactive rebase as well. That's a bit less invasive, modifying only the f16e852 commit, but from what I read, it doesn't remove the associated history. So I don't think that's the best option, though it looks like a useful thing to know about for use in less dire circumstances.

EdwardSafford-NOAA · 2022-05-19T19:32:49Z

@aerorahul @MichaelLueken-NOAA I've continued to investigate the options to remove the binary file. From what I read, after the filter command on the authoritative develop branch, a push to the develop branch on user forks should be sufficient. None of the sources I've read suggest re-forking is necessary. That said, I can't rule that possibility out.

If the decision is that we can live with the current situation, then I will not make any changes to the binary, ever. If the filter process is deemed too cumbersome/risky, then I think I should go ahead and remove the binary (knowing that doesn't solve the problem, but it does prevent any change to teh binary and thus additional growth in the size of the repo). I can adjust the install scripts to work around that and store the binary on the server (I have a local copy as well).

Thoughts?

aerorahul · 2022-05-20T13:53:14Z

@EdwardSafford-NOAA
Thank you for your continued investigation.
I think at this time removing and filtering on the authoritative develop branch should suffice.
@MichaelLueken-NOAA could send out an email with the necessary steps to take for the users.

Is there a way for @MichaelLueken-NOAA to verify (for the next few PR's that come in), to ensure that they do not contain this binary file in their history. This is just to ensure that the users did infact get the push to their develop after the filtering.

EdwardSafford-NOAA · 2022-05-20T16:04:04Z

@aerorahul Indeed there is.

Running:
git log --oneline -M --stat --follow -- util/Radiance_Monitor/image_gen/html/sum_thumbs.tar

oneline = output compact as possible
M = include file renames
stat = report diff stat
follow = follow file history

Returns this:
f16e8526 Github issue #310. Correct mean correction time series plots. Fixes #310. util/Radiance_Monitor/image_gen/html/sum_thumbs.tar | Bin 0 -> 204800 bytes 1 file changed, 0 insertions(+), 0 deletions(-)

I cloned a new GSI repo, created a new branch, testdev, switched back to the develop branch, and ran the filter command:
git filter-branch --index-filter "git rm -rf --cached --ignore-unmatch util/Radiance_Monitor/image_gen/html/sum_thumbs.tar" HEAD~8..HEAD

When I run the git log command (above) on branch develop it produces no reply -- the file is gone from both develop and the branch history. But if I run it on testdev, the file exists and the git log command produces output as above.

As a sanity check I then manually removed the file from testdev and retested the git log command:
rm util/Radiance_Monitor/image_gen/html/sum_thumbs.tar
ls util/Radiance_Monitor/image_gen/html/sum_thumbs.tar ls: cannot access util/Radiance_Monitor/image_gen/html/sum_thumbs.tar: No such file or directory

The git log command on testdev then produces this result:
git log --oneline -M --stat --follow -- util/Radiance_Monitor/image_gen/html/sum_thumbs.tar
f16e8526 Github issue #310. Correct mean correction time series plots. Fixes #310. util/Radiance_Monitor/image_gen/html/sum_thumbs.tar | Bin 0 -> 204800 bytes 1 file changed, 0 insertions(+), 0 deletions(-)

So I think running that git log command on candidate merger branches will do the trick.

MichaelLueken · 2022-05-20T16:24:42Z

@aerorahul @EdwardSafford-NOAA I have submitted an update to the review committee, so no changes will be made to the authoritative repository until that work has been approved and merged (next Wednesday). Once the work has been merged, I will use the:

git filter-branch --index-filter "git rm -rf --cached --ignore-unmatch util/Radiance_Monitor/image_gen/html/sum_thumbs.tar" HEAD~10..HEAD

command (10 rather than 8 due to the update to the develop branch this morning and the IR bug fix update middle of next week), and then let developers know to use the command in their forks so that the tar file and history are removed.

Thanks!

EdwardSafford-NOAA · 2022-05-20T20:47:53Z

@MichaelLueken-NOAA I'm good with that schedule.

I'd like to do some experimentation as part of the filter, provided you're OK with it. I want to set up two different clones before you run the filter command. After you run the filter I'll do a force pull on one and run the same filter command on the other and compare results. I'm just curious to see if both strategies work as I expect. If they do then users will have some options.

Also I assume there's some sort of backup in place for the authoritative develop branch. Everything I read about the filter command starts with some warning along the lines of "Danger Will Robinson!". I didn't have any problems with experiments on my local, expendable, clone, but I'd hate to find out about unknown unknowns the hard way.

MichaelLueken · 2022-05-23T09:22:20Z

@EdwardSafford-NOAA Yes, I don't do anything to the authoritative repository without having the authoritative develop branch cloned in a static location first (the control used for the regression testing). So, not to worry there. If there is an issue, I'd just force push this control local copy that doesn't include the filter command.

I'll let you know once PR #374 has been merged so that you can prep your experiment. Once you give me the green light, I'll disseminate the filter command (or whatever the best path forward is, once it has been decided) to the users of the NOAA-EMC/GSI repository.

EdwardSafford-NOAA · 2022-05-26T17:37:27Z

@MichaelLueken-NOAA I'm set up to run my experiments. Just let me know when you've run the filter command on the upstream develop branch and I will proceed.

MichaelLueken · 2022-05-27T12:03:34Z

@EdwardSafford-NOAA I have three updates to merge to the authoritative repository today, then I will move forward with the filter command. I'll let you know through this PR when the filter command has been run.

GitHub Issue #310 and #367. Correct RadMon's mean correction time series plots and update html generation.

MichaelLueken · 2022-05-27T16:22:45Z

@EdwardSafford-NOAA I have force pushed the filter command now. Please let me know once your experiment is complete so that I can let the developers know what they need to do to bring in the change.

EdwardSafford-NOAA · 2022-05-27T17:25:11Z

@MichaelLueken-NOAA here's what I did. I'll be glad to answer any questions. Again, thanks for your patience and, while I regret making the mistake, I have learned a great deal about git as a result.

I first used an existing cloned repo and did a force pull from upstream/develop:
git pull -f upstream develop
The log command showed the offending file was still in my branch and in the history. I manually removed it but of course the history still contained the file. Ratz, I thought that might be an easy solution. Not so.
I cloned a new repo (test1), pulled in the upstream updates:
'git pull upstream develop'
Then ran the filter (guessing 13 was the right number, maybe it's actually 12):
git filter-branch --index-filter "git rm -rf ^M --cached --ignore-unmatch util/Radiance_Monitor/image_gen/html/sum_thumbs.tar" HEAD~13..HEAD
The log command showed no history of the binary file, as expected. Then I did
git status
On branch develop
Your branch and 'origin/develop' have diverged,
and have 1 and 21 different commits each, respectively.
So I forced pushed develop to origin/develop.
Lastly I cloned repo (test2), and confirmed the binary file and history were not present. I pulled from upstream develop:
git pull upstream develop
From https://github.com/NOAA-EMC/GSI
* branch develop -> FETCH_HEAD
Already up-to-date.

Summation: I'm disappointed but not surprised to learn that a force pull from upstream/develop is insufficient to overwrite the local history. But it looks like running the filter command on user's develop branch (followed by the log command to make sure the filter reached back far enough) will fix the problem.

I didn't try re-forking but I'm sure that would work too.

GitHub Issue NOAA-EMC#310 and NOAA-EMC#367. Correct RadMon's mean correction time series plots and update html generation.

commit 112ca82 Merge: 257f6eb dd1bac5 Author: RussTreadon-NOAA <26926959+RussTreadon-NOAA@users.noreply.github.com> Date: Tue Jun 21 09:56:10 2022 -0400 Merge branch 'NOAA-EMC:develop' into feature/rm_sfcanl commit 257f6eb Merge: 9c48261 ad84f17 Author: RussTreadon-NOAA <russ.treadon@noaa.gov> Date: Mon Jun 13 14:52:28 2022 +0000 Merge branch 'develop' into feature/rm_sfcanl commit 9c48261 Merge: dc62da7 eb220ca Author: RussTreadon-NOAA <26926959+RussTreadon-NOAA@users.noreply.github.com> Date: Thu May 26 05:43:20 2022 -0400 Merge branch 'NOAA-EMC:develop' into feature/rm_sfcanl commit eb220ca Author: michael.lueken <Michael.Lueken@noaa.gov> Date: Wed May 25 16:04:25 2022 +0000 GitHub Issue NOAA-EMC#382. Add GSI fix file changes for v16.3 commit 8c22b33 Merge: a90b632 cf4b323 Author: MichaelLueken-NOAA <63728921+MichaelLueken-NOAA@users.noreply.github.com> Date: Wed May 25 15:56:49 2022 +0000 Merge pull request NOAA-EMC#374 from ADCollard/IRBugFix GitHub Issue NOAA-EMC#371. Minor bug fixes to IR processing commit dc62da7 Merge: b7afecf a90b632 Author: RussTreadon-NOAA <26926959+RussTreadon-NOAA@users.noreply.github.com> Date: Fri May 20 12:10:17 2022 -0400 Merge branch 'NOAA-EMC:develop' into feature/rm_sfcanl commit a90b632 Merge: 524527b 889cce5 Author: MichaelLueken-NOAA <63728921+MichaelLueken-NOAA@users.noreply.github.com> Date: Fri May 20 16:08:11 2022 +0000 Merge pull request NOAA-EMC#386 from HaixiaLiu-NOAA/master GitHub Issue NOAA-EMC#385. Add seviri_m09 to Radiance_Monitor util commit 889cce5 Author: Haixia.Liu <Haixia.Liu@noaa.gov> Date: Fri May 20 04:27:21 2022 +0000 GitHub Issue NOAA-EMC#385. Add seviri_m09 to Radiance_Monitor util commit b7afecf Merge: 58b52c6 524527b Author: RussTreadon-NOAA <26926959+RussTreadon-NOAA@users.noreply.github.com> Date: Thu May 19 12:46:19 2022 -0400 Merge branch 'NOAA-EMC:develop' into feature/rm_sfcanl commit 524527b Merge: 9946c69 002dc87 Author: MichaelLueken-NOAA <63728921+MichaelLueken-NOAA@users.noreply.github.com> Date: Thu May 19 16:08:48 2022 +0000 Merge pull request NOAA-EMC#379 from AndrewEichmann-NOAA/EXP-efso_fv3_issue_378 Github issue NOAA-EMC#378: refactoring of EFSOI scripts and compiled code (EFSOI and EFSOI forecast scripts) commit 9946c69 Merge: bcc0358 ccfda16 Author: MichaelLueken-NOAA <63728921+MichaelLueken-NOAA@users.noreply.github.com> Date: Thu May 19 16:05:20 2022 +0000 Merge pull request NOAA-EMC#381 from emilyhcliu/feature/gmi GitHub Issue NOAA-EMC#341. Add GMI for radmon commit bcc0358 Merge: 7146a0b 7a4fa9b Author: MichaelLueken-NOAA <63728921+MichaelLueken-NOAA@users.noreply.github.com> Date: Thu May 19 16:02:55 2022 +0000 Merge pull request NOAA-EMC#384 from christopherwharrop-noaa/feature/update-cheyenne-hpc-stack GitHub Issue NOAA-EMC#383 Update hpc-stack in Cheyenne modulefiles for GNU and Intel compilers. commit 7a4fa9b Author: Christopher Harrop <Christopher.W.Harrop@noaa.gov> Date: Thu May 19 09:23:33 2022 -0600 GitHub Issue NOAA-EMC#383 Update hpc-stack in Cheyenne modulefiles for GNU and Intel compilers. A small workaround was necessary for the GNU modulefile to avoid a dependency issue with the GNU version of hpc-stack. commit ccfda16 Author: Emily Liu <emily.liu@noaa.gov> Date: Thu May 19 02:20:09 2022 +0000 Add GMI for radmon commit 58b52c6 Merge: c4c860b 7146a0b Author: RussTreadon-NOAA <26926959+RussTreadon-NOAA@users.noreply.github.com> Date: Wed May 18 14:52:48 2022 -0400 Merge branch 'NOAA-EMC:develop' into feature/rm_sfcanl commit 7146a0b Author: Rahul Mahajan <aerorahul@users.noreply.github.com> Date: Wed May 18 11:57:08 2022 -0400 GitHub Issue NOAA-EMC#112. A refactor of CMake build framework. (NOAA-EMC#327) commit cf4b323 Author: Andrew Collard <andrew.collard@noaa.gov> Date: Fri Apr 29 21:34:22 2022 +0000 GitHub Issue NOAA-EMC#371: Bug fixes to IR processing commit 002dc87 Author: AndrewEichmann-NOAA <Andrew.Eichmann@noaa.gov> Date: Thu May 12 15:02:40 2022 -0500 Removed extraneous lines from EFSOI script, and extraneous exgdas_efsoi_fcst.sh script commit c4c860b Merge: c9ac824 34294c1 Author: RussTreadon-NOAA <russ.treadon@noaa.gov> Date: Mon May 9 16:46:28 2022 +0000 Merge branch 'develop' into feature/rm_sfcanl commit 34294c1 Merge: ad2a3c0 20cf887 Author: MichaelLueken-NOAA <63728921+MichaelLueken-NOAA@users.noreply.github.com> Date: Mon May 9 16:26:12 2022 +0000 Merge pull request NOAA-EMC#376 from EdwardSafford-NOAA/develop GitHub Issue NOAA-EMC#373. Compress RadMon data files. commit ad2a3c0 Merge: e7f8c88 845b360 Author: MichaelLueken-NOAA <63728921+MichaelLueken-NOAA@users.noreply.github.com> Date: Mon May 9 16:24:29 2022 +0000 Merge pull request NOAA-EMC#369 from MichaelLueken-NOAA/feature/wcoss2_port GitHub Issue NOAA-EMC#368. WCOSS2 port. commit 20cf887 Author: Edward.Safford <edward.safford@noaa.gov> Date: Thu May 5 12:04:30 2022 +0000 Github issue NOAA-EMC#373. Compress RadMon data files. Completes NOAA-EMC#373. commit 845b360 Author: Michael Lueken <michael.lueken@noaa.gov> Date: Fri Apr 29 11:00:52 2022 +0000 GitHub Issue NOAA-EMC#368. WCOSS2 port. commit c9ac824 Merge: e577941 e7f8c88 Author: RussTreadon-NOAA <26926959+RussTreadon-NOAA@users.noreply.github.com> Date: Tue May 3 10:42:43 2022 -0400 Merge branch 'NOAA-EMC:develop' into feature/rm_sfcanl commit e7f8c88 Merge: 586c2df 0a5daea Author: MichaelLueken-NOAA <63728921+MichaelLueken-NOAA@users.noreply.github.com> Date: Tue May 3 10:08:34 2022 -0400 Merge pull request NOAA-EMC#372 from RussTreadon-NOAA/feature/interp GitHub Issue NOAA-EMC#370: use nf90_inq_varid to set integer addresses for lon and lat variables commit 0a5daea Author: RussTreadon-NOAA <russ.treadon@noaa.gov> Date: Fri Apr 29 21:36:35 2022 +0000 GitHub Issue NOAA-EMC/GSI NOAA-EMC#370: use nf90_inq_varid to set integer addresses for lon and lat variables commit e577941 Merge: be550bf 586c2df Author: RussTreadon-NOAA <26926959+RussTreadon-NOAA@users.noreply.github.com> Date: Tue May 3 09:52:08 2022 -0400 Merge branch 'NOAA-EMC:develop' into feature/rm_sfcanl commit 586c2df Merge: 87fe77d f16e852 Author: MichaelLueken-NOAA <63728921+MichaelLueken-NOAA@users.noreply.github.com> Date: Tue May 3 09:46:33 2022 -0400 Merge pull request NOAA-EMC#366 from EdwardSafford-NOAA/develop GitHub Issue NOAA-EMC#310 and NOAA-EMC#367. Correct RadMon's mean correction time series plots and update html generation. commit f16e852 Author: edward.safford <edward.safford@noaa.gov> Date: Fri Apr 29 14:39:22 2022 +0000 Github issue NOAA-EMC#310. Correct mean correction time series plots. Fixes NOAA-EMC#310. commit be550bf Merge: c0a5204 114ed31 Author: RussTreadon-NOAA <26926959+RussTreadon-NOAA@users.noreply.github.com> Date: Mon May 2 06:25:23 2022 -0400 Merge branch 'NOAA-EMC:develop' into feature/rm_sfcanl commit c0a5204 Merge: 8b376d1 498896b Author: RussTreadon-NOAA <26926959+RussTreadon-NOAA@users.noreply.github.com> Date: Mon Apr 25 13:22:30 2022 -0400 Merge branch 'NOAA-EMC:develop' into feature/rm_sfcanl commit 8b376d1 Merge: 91a8077 0c6548e Author: RussTreadon-NOAA <26926959+RussTreadon-NOAA@users.noreply.github.com> Date: Wed Apr 20 13:53:51 2022 -0400 Merge branch 'NOAA-EMC:master' into feature/rm_sfcanl commit 91a8077 Merge: dec3299 7201778 Author: RussTreadon-NOAA <26926959+RussTreadon-NOAA@users.noreply.github.com> Date: Wed Apr 13 10:27:36 2022 -0400 Merge branch 'NOAA-EMC:master' into feature/rm_sfcanl commit dec3299 Merge: 6204f98 5936a23 Author: RussTreadon-NOAA <26926959+RussTreadon-NOAA@users.noreply.github.com> Date: Tue Apr 5 10:49:24 2022 -0400 Merge branch 'NOAA-EMC:master' into feature/rm_sfcanl commit 6204f98 Merge: f7a1495 affe4ed Author: RussTreadon-NOAA <26926959+RussTreadon-NOAA@users.noreply.github.com> Date: Thu Mar 31 12:38:40 2022 -0400 Merge branch 'NOAA-EMC:master' into feature/rm_sfcanl commit f7a1495 Merge: b592666 ef237ce Author: RussTreadon-NOAA <26926959+RussTreadon-NOAA@users.noreply.github.com> Date: Thu Mar 24 08:57:46 2022 -0400 Merge branch 'NOAA-EMC:master' into feature/rm_sfcanl commit b592666 Merge: d0f7c20 47ee70b Author: RussTreadon-NOAA <26926959+RussTreadon-NOAA@users.noreply.github.com> Date: Thu Mar 10 09:13:14 2022 -0500 Merge branch 'NOAA-EMC:master' into feature/rm_sfcanl commit d0f7c20 Merge: ed94193 828c0cf Author: RussTreadon-NOAA <26926959+RussTreadon-NOAA@users.noreply.github.com> Date: Wed Mar 2 10:35:21 2022 -0500 Merge branch 'NOAA-EMC:master' into feature/rm_sfcanl commit ed94193 Merge: c63bd77 963b7e5 Author: RussTreadon-NOAA <russ.treadon@noaa.gov> Date: Tue Mar 1 16:04:48 2022 +0000 Merge branch 'master' at 963b7e5 into feature/rm_sfcanl Conflicts: scripts/exglobal_atmos_analysis.sh commit c63bd77 Merge: 39912e1 0444258 Author: RussTreadon-NOAA <26926959+RussTreadon-NOAA@users.noreply.github.com> Date: Tue Feb 15 06:06:10 2022 -0500 Merge branch 'NOAA-EMC:master' into feature/rm_sfcanl commit 39912e1 Merge: f0161c8 9e765da Author: RussTreadon-NOAA <26926959+RussTreadon-NOAA@users.noreply.github.com> Date: Tue Jan 11 06:40:58 2022 -0500 Merge branch 'NOAA-EMC:master' into feature/rm_sfcanl commit f0161c8 Merge: a75d6ed a62dec6 Author: RussTreadon-NOAA <26926959+RussTreadon-NOAA@users.noreply.github.com> Date: Tue Dec 14 11:40:31 2021 -0500 Merge branch 'NOAA-EMC:master' into feature/rm_sfcanl commit a75d6ed Author: russ.treadon <Russ.Treadon@noaa.gov> Date: Tue Dec 14 14:38:57 2021 +0000 GitHub Issue NOAA-EMC#266: add DOGAUSFCANL capability back to JGLOBAL_ATMOS_ANALYSIS_CALC and exglobal_atmos_analysis_calc.sh commit 9422758 Author: russ.treadon <Russ.Treadon@noaa.gov> Date: Mon Dec 13 14:39:14 2021 +0000 GitHub Issue NOAA-EMC#266: remove DOGCYCLE and DOGAUSFCANL scripting and variables from j-jobs and scripts * jobs/JGDAS_ATMOS_ANALYSIS_DIAG - remove DOGCYCLE and DOGAUSFCANL * jobs/JGLOBAL_ATMOS_ANALYSIS - remove DOGCYCLE and DOGAUSFCANL * jobs/JGLOBAL_ATMOS_ANALYSIS_CALC - remove DOGCYCLE and DOGAUSFCANL * scripts/exglobal_atmos_analysis.sh - remove DOGCYCLE scripting and DOGAUSFCANL variables * scripts/exglobal_atmos_analysis_calc.sh - remove DOGAUSFCANL scripting

MichaelLueken requested review from MichaelLueken and dtkleist April 26, 2022 09:08

MichaelLueken linked an issue Apr 26, 2022 that may be closed by this pull request

Fix RadMon time series plot problem #310

Closed

EdwardSafford-NOAA force-pushed the develop branch from ba49eae to 622e07c Compare April 26, 2022 14:38

EdwardSafford-NOAA mentioned this pull request Apr 28, 2022

Update RadMon html generation #367

Closed

EdwardSafford-NOAA force-pushed the develop branch from 622e07c to 7f41bb4 Compare April 29, 2022 13:32

EdwardSafford-NOAA force-pushed the develop branch from 7f41bb4 to b7631a3 Compare April 29, 2022 14:40

MichaelLueken linked an issue Apr 29, 2022 that may be closed by this pull request

Update RadMon html generation #367

Closed

DavidHuber-NOAA approved these changes May 2, 2022

View reviewed changes

Github issue NOAA-EMC#310. Correct mean correction time series plots. F…

f16e852

…ixes NOAA-EMC#310.

EdwardSafford-NOAA force-pushed the develop branch from 43c54de to f16e852 Compare May 2, 2022 14:02

MichaelLueken changed the title ~~Correct RadMon's mean correction time series plots.~~ GitHub Issue NOAA-EMC/GSI#310 and #367. Correct RadMon's mean correction time series plots and update html generation. May 3, 2022

MichaelLueken merged commit 586c2df into NOAA-EMC:develop May 3, 2022

MichaelLueken added a commit that referenced this pull request May 27, 2022

Merge pull request #366 from EdwardSafford-NOAA/develop

f8b420f

GitHub Issue #310 and #367. Correct RadMon's mean correction time series plots and update html generation.

GitHub Issue NOAA-EMC/GSI#310 and #367. Correct RadMon's mean correction time series plots and update html generation. #366

GitHub Issue NOAA-EMC/GSI#310 and #367. Correct RadMon's mean correction time series plots and update html generation. #366

Conversation

EdwardSafford-NOAA commented Apr 25, 2022

MichaelLueken commented Apr 26, 2022

EdwardSafford-NOAA commented Apr 26, 2022 • edited Loading

MichaelLueken commented Apr 26, 2022

EdwardSafford-NOAA commented Apr 26, 2022

MichaelLueken commented Apr 26, 2022

EdwardSafford-NOAA commented Apr 29, 2022

MichaelLueken commented Apr 29, 2022

EdwardSafford-NOAA commented Apr 29, 2022

MichaelLueken commented Apr 29, 2022

EdwardSafford-NOAA commented Apr 29, 2022

DavidHuber-NOAA left a comment

Choose a reason for hiding this comment

MichaelLueken commented May 2, 2022

EdwardSafford-NOAA commented May 2, 2022

MichaelLueken commented May 3, 2022

aerorahul commented May 10, 2022

EdwardSafford-NOAA commented May 10, 2022

aerorahul commented May 11, 2022

EdwardSafford-NOAA commented May 11, 2022

aerorahul commented May 11, 2022

EdwardSafford-NOAA commented May 11, 2022

aerorahul commented May 11, 2022

EdwardSafford-NOAA commented May 11, 2022

EdwardSafford-NOAA commented May 11, 2022

aerorahul commented May 11, 2022

EdwardSafford-NOAA commented May 12, 2022

EdwardSafford-NOAA commented May 19, 2022

aerorahul commented May 20, 2022

EdwardSafford-NOAA commented May 20, 2022

MichaelLueken commented May 20, 2022

EdwardSafford-NOAA commented May 20, 2022

MichaelLueken commented May 23, 2022

EdwardSafford-NOAA commented May 26, 2022

MichaelLueken commented May 27, 2022

MichaelLueken commented May 27, 2022

EdwardSafford-NOAA commented May 27, 2022

EdwardSafford-NOAA commented Apr 26, 2022 •

edited

Loading