add pm2.5 DA for rrfs-smoke #482

hongli-wang · 2022-10-04T17:27:00Z

Add PM2.5 DA capability for RRFS-SMOKE.

CoryMartin-NOAA · 2022-11-29T19:50:17Z

@hongli-wang I'm going to be starting on the review for this (sorry it has taken so long). Can you merge in 'develop' to your branch and we will get started. Do you know of anyone who knows GSI and AQ well enough to be a second reviewer besides myself?

hongli-wang · 2022-11-29T20:09:09Z

@hongli-wang I'm going to be starting on the review for this (sorry it has taken so long). Can you merge in 'develop' to your branch and we will get started. Do you know of anyone who knows GSI and AQ well enough to be a second reviewer besides myself?

Do you mean rebase my feature/RRFS-CMAQ branch to the EMC GSI develop branch? What I see now is that my branch doesn't have conflicts and can merge to EMC GSI develop branch.

Thanks for reviewing my GSI code. The others I can recommend are Ting Lei, Ming Hu and Mariusz Pagowski. Ting reviewed my previous update on RRFS-CMAQ DA, so if he would like to review the code this time would be best.

CoryMartin-NOAA · 2022-11-29T20:10:27Z

@TingLei-daprediction would you have time to be able to provide a review of this PR alongside my review?

CoryMartin-NOAA · 2022-11-29T20:11:06Z

@hongli-wang yes I see there are no conflicts so it should be fine (at least for now). I will proceed with starting my review.

TingLei-daprediction · 2022-11-29T20:24:18Z

@CoryMartin-NOAA Sure. I will begin my review as soon as possible.

CoryMartin-NOAA

A couple of comments here from the first round of review.

src/gsi/gsi_rfv3io_mod.f90

src/gsi/intpm2_5.f90

src/gsi/setuppm2_5.f90

src/gsi/stppm2_5.f90

src/gsi/gsi_rfv3io_mod.f90

src/gsi/intpm2_5.f90

src/gsi/setuppm2_5.f90

src/gsi/stppm2_5.f90

TingLei-NOAA · 2022-12-06T17:25:14Z

@hongli-wang Have you finished the existing regression tests for this PR? I know they are only available on hera now.

hongli-wang · 2022-12-06T18:11:36Z

@hongli-wang Have you finished the existing regression tests for this PR? I know they are only available on hera now.

Do you know where I can find guidance on the regression test? I haven't done that.

CoryMartin-NOAA · 2022-12-06T18:47:40Z

@hongli-wang @TingLei-NOAA , I/we (the GSI review team) will handle the regression testing, but I wanted to wait until it was closer to the 'final' version of the PR before submitting the tests.

hongli-wang

I am not sure why my replies are shown as comments.

src/gsi/gsi_rfv3io_mod.f90

src/gsi/intpm2_5.f90

src/gsi/setuppm2_5.f90

src/gsi/stppm2_5.f90

hongli-wang · 2022-12-06T19:17:04Z

A couple of comments here from the first round of review.

Hi Corry,

Thanks for your comments. I will address them in my latter commit.

CoryMartin-NOAA · 2022-12-06T19:21:21Z

No need to close this PR, we can keep it open for subsequent commits

hongli-wang · 2022-12-06T19:24:09Z

No need to close this PR, we can keep it open for subsequent commits

Understand. Thank you!

TingLei-NOAA · 2022-12-06T19:46:42Z

@hongli-wang Have you finished the existing regression tests for this PR? I know they are only available on hera now.

Do you know where I can find guidance on the regression test? I haven't done that.
@RussTreadon-NOAA has a wiki on regression tests which is to be updated. I will open an issue soon to document what is being done on hera with the link to former.

TingLei-NOAA · 2022-12-06T20:00:15Z

@cory Martin - NOAA Federal ***@***.***> When some developers have no access to hera, the reviewers take care of the regression tests is essential . However, for those with access to hera, the regression tests would be a necessary tool for their development , even before they make their PR , not only as a criterion to pass but also as a helping tool . In fact, i would think it would be helpful if every PR could offer their own regression test to verify their new functions to the existing regression tests, though this seems not doable in the near future. So, when as you stated, the reviewing side would take care of the regression tests, I would still open an issue with the link to GSI wiki on how to do the regression tests and add my update on current practice on hera to provide the options for GSI developers on hera.

…

______________________________ Ting Lei Physical Scientist, Contractor with Lynker in support of EMC/NCEP/NWS/NOAA 5830 University Research Ct., Cubicle 2765 College Park, MD 20740 ***@***.*** 301-683-3624

On Tue, Dec 6, 2022 at 1:47 PM Cory Martin ***@***.***> wrote: @hongli-wang <https://github.com/hongli-wang> @TingLei-NOAA <https://github.com/TingLei-NOAA> , I/we (the GSI review team) will handle the regression testing, but I wanted to wait until it was closer to the 'final' version of the PR before submitting the tests. — Reply to this email directly, view it on GitHub <#482 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/APEFS7DPYTHIZHPLOSSYG4LWL6C5RANCNFSM6AAAAAAQ4ZE2IE> . You are receiving this because you were mentioned.Message ID: ***@***.***>

hu5970 · 2022-12-06T23:39:57Z

More developers can run regression test suite, the better for code development and review. We should update wiki page on how to run regression test as the steps may already be changed, at least they are not matching the steps I did.

hongli-wang · 2022-12-12T16:56:39Z

No need to close this PR, we can keep it open for subsequent commits

@CoryMartin-NOAA @TingLei-daprediction

Hi Cory and Ting,

I had pushed back my changes. Would you please review the codes again?

Thanks again for your suggestions and comments!

Hongli

CoryMartin-NOAA · 2022-12-14T20:21:06Z

@hongli-wang thank you for addressing my comments!
@TingLei-NOAA please review again when you get a chance.

I'm not sure I'll be able to get to do the regression tests before I go on leave, but will do so in the new year. Once we know those pass + 2 thumbs up reviews, we can proceed with the merge.

RussTreadon-NOAA · 2023-01-24T10:39:47Z

@hongli-wang , once requested changes are made and your regression tests (ctest) results are posted I can approve this PR.

hongli-wang · 2023-01-24T16:10:39Z

@hongli-wang , once requested changes are made and your regression tests (ctest) results are posted I can approve this PR.

@RussTreadon-NOAA I had changed the variables (iuv,ndynvario3d,ntracerio3d) to i_kind in gsi_rfv3io_mod.f90, and deleted unused commented variable (penalty) in intpm2_5.f90. The changes had been pushed back.
Please let me know if you see other changes are required. Thanks.

RussTreadon-NOAA · 2023-01-24T16:18:42Z

Changes look good. Thank you @hongli-wang . Would you please post results from your execution of the regression (ctest) tests?

@TingLei-NOAA , you have several unresolved conversations in this PR. Would you please check these open conversations and mark them as resolved if appropriate.

TingLei-NOAA · 2023-01-24T16:32:12Z

@russ Treadon - NOAA Federal ***@***.***> Sure, all those conversations I initiated were resolved. However, I think I don't have the permission to mark those conversations resolved. I think you (with the write permissions to EMC GSI ) or @hongli-wang (the author) could do it. So, either of you do that will be ok to me and thanks !

…

______________________________ Ting Lei Physical Scientist, Contractor with Lynker in support of EMC/NCEP/NWS/NOAA 5830 University Research Ct., Cubicle 2765 College Park, MD 20740 ***@***.*** 301-683-3624

On Tue, Jan 24, 2023 at 11:18 AM RussTreadon-NOAA ***@***.***> wrote: Changes look good. Thank you @hongli-wang <https://github.com/hongli-wang> . Would you please post results from your execution of the regression (ctest) tests? @TingLei-NOAA <https://github.com/TingLei-NOAA> , you have several unresolved conversations in this PR. Would you please check these open conversations and mark them as resolved if appropriate. — Reply to this email directly, view it on GitHub <#482 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/APEFS7CXTVUSGZF2EE4JO6LWT76G5ANCNFSM6AAAAAAQ4ZE2IE> . You are receiving this because you were mentioned.Message ID: ***@***.***>

hongli-wang · 2023-01-24T16:39:57Z

Changes look good. Thank you @hongli-wang . Would you please post results from your execution of the regression (ctest) tests?

@TingLei-NOAA , you have several unresolved conversations in this PR. Would you please check these open conversations and mark them as resolved if appropriate.

@RussTreadon-NOAA The regression test under my Hera account doesn't work well.
Yesterday I followed the guidance on regression test, and ran with ctest in the dir build of my fork, it failed. However, I don't think this is a code issue since Cory had a successful test.

FYI. I do change the regression_var.sh. I am wondering if it is the HPC setup issue.

Here is the first regression test if you like to have a look. It seems the gsi.x (both develop and mine) cann't handle the namlist file:
/scratch1/BMC/wrfruc/hwang/smoke/ctest/tmpreg_global_3dvar/global_3dvar_loproc_updat

RussTreadon-NOAA · 2023-01-24T16:43:32Z

@russ Treadon - NOAA Federal @.> Sure, all those conversations I initiated were resolved. However, I think I don't have the permission to mark those conversations resolved. I think you (with the write permissions to EMC GSI ) or @hongli-wang (the author) could do it. So, either of you do that will be ok to me and thanks !
…
______________________________ Ting Lei Physical Scientist, Contractor with Lynker in support of EMC/NCEP/NWS/NOAA 5830 University Research Ct., Cubicle 2765 College Park, MD 20740 @. 301-683-3624
On Tue, Jan 24, 2023 at 11:18 AM RussTreadon-NOAA @.> wrote: Changes look good. Thank you @hongli-wang https://github.com/hongli-wang . Would you please post results from your execution of the regression (ctest) tests? @TingLei-NOAA https://github.com/TingLei-NOAA , you have several unresolved conversations in this PR. Would you please check these open conversations and mark them as resolved if appropriate. — Reply to this email directly, view it on GitHub <#482 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/APEFS7CXTVUSGZF2EE4JO6LWT76G5ANCNFSM6AAAAAAQ4ZE2IE . You are receiving this because you were mentioned.Message ID: @.>

@TingLei-NOAA , did you try resolving the conversations by clicking on Resolve conversation?

RussTreadon-NOAA · 2023-01-24T16:46:02Z

@hongli-wang , if you want me to examine this failure I need to know the path to the build directory from which you executed ctest.

hongli-wang · 2023-01-24T16:50:20Z

@hongli-wang , if you want me to examine this failure I need to know the path to the build directory from which you executed ctest.

@RussTreadon-NOAA
My gsi:
/scratch1/BMC/wrfruc/hwang/smoke/ctest/GSI/build
EMC develop:
/scratch1/BMC/wrfruc/hwang/smoke/ctest/develop

Thanks for looking into this.

hongli-wang · 2023-01-24T17:01:29Z

@russ Treadon - NOAA Federal @.***> Sure, all those conversations I initiated were resolved. However, I think I don't have the permission to mark those conversations resolved. I think you (with the write permissions to EMC GSI ) or @hongli-wang (the author) could do it. So, either of you do that will be ok to me and thanks !
…

@TingLei-NOAA @RussTreadon-NOAA
I went though conversations and had makes a few as resolved where I have the permission to change their status. Thank you all for your time on this PR. Hongli

RussTreadon-NOAA · 2023-01-24T17:05:07Z

@hongli-wang , it looks like you did not include --recursive when you executed git clone to populate /scratch1/BMC/wrfruc/hwang/smoke/ctest/GSI. Directory /scratch1/BMC/wrfruc/hwang/smoke/ctest/GSI/fix is empty.

Log file /scratch1/BMC/wrfruc/hwang/smoke/ctest/GSI/regression/global_3dvar_loproc_updat.out contains numerous No such file messages.

+ /bin/cp /scratch1/BMC/wrfruc/hwang/smoke/ctest/GSI/fix/global_anavinfo.l127.txt ./anavinfo
/bin/cp: cannot stat ?/scratch1/BMC/wrfruc/hwang/smoke/ctest/GSI/fix/global_anavinfo.l127.txt?: No such file or directory
+ /bin/cp /scratch1/BMC/wrfruc/hwang/smoke/ctest/GSI/fix/Big_Endian/global_berror.l127y98.f77 ./berror_stats
/bin/cp: cannot stat ?/scratch1/BMC/wrfruc/hwang/smoke/ctest/GSI/fix/Big_Endian/global_berror.l127y98.f77?: No such file or directory
+ /bin/cp /scratch1/BMC/wrfruc/hwang/smoke/ctest/GSI/fix/global_hybens_info.l127.txt ./hybens_info
/bin/cp: cannot stat ?/scratch1/BMC/wrfruc/hwang/smoke/ctest/GSI/fix/global_hybens_info.l127.txt?: No such file or directory

@hu5970 , step 1 of GSI Ctests (regression tests) needs --recursive on the git clone.

TingLei-NOAA · 2023-01-24T17:06:41Z

@hongli-wang Thanks for marking them resolved.
@RussTreadon-NOAA no "resolved " button appear to me , i guess, for the permission issue I mentioned previously.

RussTreadon-NOAA · 2023-01-24T17:10:13Z

@hongli-wang Thanks for marking them resolved. @RussTreadon-NOAA no "resolved " button appear to me , i guess, for the permission issue I mentioned previously.

Thank you @TingLei-NOAA for resolving the conversations you initiated. Please do so in future reviews. The review team can not process a PR if conversations remain open.

hongli-wang · 2023-01-24T17:10:33Z

@hongli-wang , it looks like you did not include --recursive when you executed git clone to populate /scratch1/BMC/wrfruc/hwang/smoke/ctest/GSI. Directory /scratch1/BMC/wrfruc/hwang/smoke/ctest/GSI/fix is empty.

Log file /scratch1/BMC/wrfruc/hwang/smoke/ctest/GSI/regression/global_3dvar_loproc_updat.out contains numerous No such file messages.
+ /bin/cp /scratch1/BMC/wrfruc/hwang/smoke/ctest/GSI/fix/global_anavinfo.l127.txt ./anavinfo
/bin/cp: cannot stat ?/scratch1/BMC/wrfruc/hwang/smoke/ctest/GSI/fix/global_anavinfo.l127.txt?: No such file or directory
+ /bin/cp /scratch1/BMC/wrfruc/hwang/smoke/ctest/GSI/fix/Big_Endian/global_berror.l127y98.f77 ./berror_stats
/bin/cp: cannot stat ?/scratch1/BMC/wrfruc/hwang/smoke/ctest/GSI/fix/Big_Endian/global_berror.l127y98.f77?: No such file or directory
+ /bin/cp /scratch1/BMC/wrfruc/hwang/smoke/ctest/GSI/fix/global_hybens_info.l127.txt ./hybens_info
/bin/cp: cannot stat ?/scratch1/BMC/wrfruc/hwang/smoke/ctest/GSI/fix/global_hybens_info.l127.txt?: No such file or directory
@hu5970 , step 1 of GSI Ctests (regression tests) needs --recursive on the git clone.

@RussTreadon-NOAA You are correct. I did not include --recursive when I checked my GSI yesterday. I will have another try. thanks.

TingLei-daprediction · 2023-01-24T17:15:00Z

@hongli-wang Thanks for marking them resolved. @RussTreadon-NOAA no "resolved " button appear to me , i guess, for the permission issue I mentioned previously.

Thank you @TingLei-NOAA for resolving the conversations you initiated. Please do so in future reviews. The review team can not process a PR if conversations remain open.

@RussTreadon-NOAA As I mentioned , those conversations could only be "resolved" by persons with write permission and the author, and hence, I have no "right" to "resolve " conversations. (this time , Hongli resolved those conversations. ). Hope this explanation make sense to you.

RussTreadon-NOAA · 2023-01-24T17:21:22Z

@hongli-wang Thanks for marking them resolved. @RussTreadon-NOAA no "resolved " button appear to me , i guess, for the permission issue I mentioned previously.

Thank you @TingLei-NOAA for resolving the conversations you initiated. Please do so in future reviews. The review team can not process a PR if conversations remain open.

@RussTreadon-NOAA As I mentioned , those conversations could only be "resolved" by persons with write permission and the author, and hence, I have no "right" to "resolve " conversations. (this time , Hongli resolved those conversations. ). Hope this explanation make sense to you.

@TingLei-NOAA . I searched github documentation and see what you are saying. It's always good to learn new things. Thanks.

TingLei-NOAA · 2023-01-24T17:39:59Z

@RussTreadon-NOAA Thanks for the confirmation. Sure, that is also what I learned not long ago!. Thanks.

hongli-wang · 2023-01-24T21:42:00Z

@hongli-wang , it looks like you did not include --recursive when you executed git clone to populate /scratch1/BMC/wrfruc/hwang/smoke/ctest/GSI. Directory /scratch1/BMC/wrfruc/hwang/smoke/ctest/GSI/fix is empty.
Log file /scratch1/BMC/wrfruc/hwang/smoke/ctest/GSI/regression/global_3dvar_loproc_updat.out contains numerous No such file messages.
+ /bin/cp /scratch1/BMC/wrfruc/hwang/smoke/ctest/GSI/fix/global_anavinfo.l127.txt ./anavinfo
/bin/cp: cannot stat ?/scratch1/BMC/wrfruc/hwang/smoke/ctest/GSI/fix/global_anavinfo.l127.txt?: No such file or directory
+ /bin/cp /scratch1/BMC/wrfruc/hwang/smoke/ctest/GSI/fix/Big_Endian/global_berror.l127y98.f77 ./berror_stats
/bin/cp: cannot stat ?/scratch1/BMC/wrfruc/hwang/smoke/ctest/GSI/fix/Big_Endian/global_berror.l127y98.f77?: No such file or directory
+ /bin/cp /scratch1/BMC/wrfruc/hwang/smoke/ctest/GSI/fix/global_hybens_info.l127.txt ./hybens_info
/bin/cp: cannot stat ?/scratch1/BMC/wrfruc/hwang/smoke/ctest/GSI/fix/global_hybens_info.l127.txt?: No such file or directory
@hu5970 , step 1 of GSI Ctests (regression tests) needs --recursive on the git clone.
@RussTreadon-NOAA You are correct. I did not include --recursive when I checked my GSI yesterday. I will have another try. thanks.

@RussTreadon-NOAA @CoryMartin-NOAA My regression test is pending and no progress. Just wondering if any of you can run a regression test. Thanks.

RussTreadon-NOAA · 2023-01-24T21:43:50Z

@hongli-wang , it looks like you did not include --recursive when you executed git clone to populate /scratch1/BMC/wrfruc/hwang/smoke/ctest/GSI. Directory /scratch1/BMC/wrfruc/hwang/smoke/ctest/GSI/fix is empty.
Log file /scratch1/BMC/wrfruc/hwang/smoke/ctest/GSI/regression/global_3dvar_loproc_updat.out contains numerous No such file messages.
+ /bin/cp /scratch1/BMC/wrfruc/hwang/smoke/ctest/GSI/fix/global_anavinfo.l127.txt ./anavinfo
/bin/cp: cannot stat ?/scratch1/BMC/wrfruc/hwang/smoke/ctest/GSI/fix/global_anavinfo.l127.txt?: No such file or directory
+ /bin/cp /scratch1/BMC/wrfruc/hwang/smoke/ctest/GSI/fix/Big_Endian/global_berror.l127y98.f77 ./berror_stats
/bin/cp: cannot stat ?/scratch1/BMC/wrfruc/hwang/smoke/ctest/GSI/fix/Big_Endian/global_berror.l127y98.f77?: No such file or directory
+ /bin/cp /scratch1/BMC/wrfruc/hwang/smoke/ctest/GSI/fix/global_hybens_info.l127.txt ./hybens_info
/bin/cp: cannot stat ?/scratch1/BMC/wrfruc/hwang/smoke/ctest/GSI/fix/global_hybens_info.l127.txt?: No such file or directory
@hu5970 , step 1 of GSI Ctests (regression tests) needs --recursive on the git clone.
@RussTreadon-NOAA You are correct. I did not include --recursive when I checked my GSI yesterday. I will have another try. thanks.
@RussTreadon-NOAA @CoryMartin-NOAA My regression test is pending and no progress. Just wondering if any of you can run a regression test. Thanks.

@hongli-wang , let me try later tonight.

RussTreadon-NOAA · 2023-01-25T01:55:34Z

ctests work for me

Hera(hfe12):/scratch1/NCEPDEV/da/Russ.Treadon/git/gsi/pr482/build$ ctest -j 9
Test project /scratch1/NCEPDEV/da/Russ.Treadon/git/gsi/pr482/build
    Start 1: global_3dvar
    Start 2: global_4dvar
    Start 3: global_4denvar
    Start 4: hwrf_nmm_d2
    Start 5: hwrf_nmm_d3
    Start 6: rtma
    Start 7: rrfs_3denvar_glbens
    Start 8: netcdf_fv3_regional
    Start 9: global_enkf
1/9 Test #7: rrfs_3denvar_glbens ..............   Passed  485.53 sec
2/9 Test #8: netcdf_fv3_regional ..............   Passed  542.94 sec
3/9 Test #9: global_enkf ......................   Passed  601.69 sec
4/9 Test #5: hwrf_nmm_d3 ......................   Passed  674.07 sec
5/9 Test #4: hwrf_nmm_d2 ......................   Passed  787.56 sec
6/9 Test #2: global_4dvar .....................   Passed  1321.79 sec
7/9 Test #6: rtma .............................   Passed  1449.58 sec
8/9 Test #3: global_4denvar ...................   Passed  1803.40 sec
9/9 Test #1: global_3dvar .....................   Passed  1922.81 sec

100% tests passed, 0 tests failed out of 9

Total Test time (real) = 1922.81 sec
Hera(hfe12):/scratch1/NCEPDEV/da/Russ.Treadon/git/gsi/pr482/build$

My pr482 directory is the current head of your feature/RRFS-CMAQ

Hera(hfe12):/scratch1/NCEPDEV/da/Russ.Treadon/git/gsi/pr482/build$ git branch
* feature/RRFS-CMAQ
  master
Hera(hfe12):/scratch1/NCEPDEV/da/Russ.Treadon/git/gsi/pr482/build$ git log --oneline |head -3
08b212f4c Change variables(iuv,ndynvario3d,ntracerio3d) to i_kind and clear code.
b6ab52aa5 update submodule to resolve change
7dbfb184c Merge remote-tracking branch 'upstream/develop' into feature/RRFS-CMAQ

RussTreadon-NOAA · 2023-01-25T13:42:08Z

@TingLei-daprediction , @TingLei-NOAA would you please add your review to this PR.

@hongli-wang , any luck with the regression tests?

hongli-wang · 2023-01-25T14:06:03Z

@TingLei-daprediction , @TingLei-NOAA would you please add your review to this PR.

@hongli-wang , any luck with the regression tests?

@RussTreadon-NOAA The test of global_enkf failed. Others passed.
Start 1: [=[global_3dvar]=]
Start 2: [=[global_4dvar]=]
Start 3: [=[global_4denvar]=]
Start 4: [=[hwrf_nmm_d2]=]
Start 5: [=[hwrf_nmm_d3]=]
Start 6: [=[rtma]=]
Start 7: [=[rrfs_3denvar_glbens]=]
Start 8: [=[netcdf_fv3_regional]=]
Start 9: [=[global_enkf]=]
1/9 Test #7: [=[rrfs_3denvar_glbens]=] ........ Passed 1327.02 sec
2/9 Test #9: [=[global_enkf]=] ................***Failed 1443.16 sec
3/9 Test #8: [=[netcdf_fv3_regional]=] ........ Passed 1624.90 sec
4/9 Test #4: [=[hwrf_nmm_d2]=] ................ Passed 1629.21 sec
5/9 Test #5: [=[hwrf_nmm_d3]=] ................ Passed 1636.73 sec

6/9 Test #2: [=[global_4dvar]=] ............... Passed 2044.37 sec
7/9 Test #3: [=[global_4denvar]=] ............. Passed 2209.98 sec
8/9 Test #6: [=[rtma]=] ....................... Passed 2232.52 sec
9/9 Test #1: [=[global_3dvar]=] ............... Passed 2510.73 sec

89% tests passed, 1 tests failed out of 9

Total Test time (real) = 2510.74 sec

The following tests FAILED:
9 - [=[global_enkf]=] (Failed)

My build on Hera:
/scratch1/BMC/wrfruc/hwang/smoke/ctest/GSI/build/

Please feel free to have a look. Thanks again.

RussTreadon-NOAA · 2023-01-25T14:19:24Z

@hongli-wang , a check of file global_enkf_regression_results.txt in /scratch1/BMC/wrfruc/hwang/smoke/ctest/tmpreg_global_enkf/tmpreg_global_enkf/global_enkf_loproc_updat_vs_global_enkf_loproc_contrl/ shows that the failure is due to a run time check.

The runtime for global_enkf_hiproc_updat is 64.759394 seconds.  This has exceeded maximum allowable threshold time of 64.704082 seconds,
resulting in Failure timethresh2 of the regression test.

The difference is 0.05 second. This is a non-fatal fail.

Given @CoryMartin-NOAA and @TingLei-NOAA approvals, I'll merge this PR into develop.

CoryMartin-NOAA · 2023-01-25T14:20:54Z

Thanks @RussTreadon-NOAA for helping finish this up, I wanted a second set of eyes given that I contributed through the merging of develop + modifying the fix/ path.

hongli-wang · 2023-01-25T14:28:58Z

Thanks @RussTreadon-NOAA for helping finish this up, I wanted a second set of eyes given that I contributed through the merging of develop + modifying the fix/ path.

@CoryMartin-NOAA @TingLei-NOAA @RussTreadon-NOAA @ShunLiu-NOAA @hu5970
Thanks Cory for merging of develop and updating fix in my fork. I am not familiar with that part, that saves me tons of time! Thanks Cory and Ting for reviews since the DA work for RRFS-CMAQ and now RRFS-smoke.

Thank you ALL for your time and contributions! Appreciated!

Hongli

hongli-wang force-pushed the feature/RRFS-CMAQ branch from c0969b6 to 5572c26 Compare October 4, 2022 18:03

CoryMartin-NOAA self-requested a review November 28, 2022 17:05

CoryMartin-NOAA requested a review from TingLei-NOAA November 29, 2022 20:32

CoryMartin-NOAA reviewed Nov 30, 2022

View reviewed changes