Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Jet modulefiles to Rocky8 #733

Merged

Conversation

InnocentSouopgui-NOAA
Copy link
Contributor

@InnocentSouopgui-NOAA InnocentSouopgui-NOAA commented Apr 5, 2024

Description

  • Jet has been upgraded to the Rocky8 Linux OS and present module file no longer works
  • Update Jet module file to use Rocky8 installation of spack-stack;

Fixes #732
Refs NOAA-EMC/global-workflow#2377

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

This change affects only Jet, there is no need to test on other systems
Cycled experiments (48+ hours) at resolutions

  • 96/48 on xjet and kjet
  • 192/96 on kjet
  • 384/192 on kjet

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • New and existing tests pass with my changes
  • Any dependent changes have been merged and published

@InnocentSouopgui-NOAA
Copy link
Contributor Author

@ShunLiu-NOAA
Have you had the chance to look at this pull request yet?

@BijuThomas-NOAA
Copy link

Let me do a test with the module files from migration/jet-rocky8 in HAFS/GSI

@ShunLiu-NOAA
Copy link
Contributor

@DavidHuber-NOAA Do you have a chance to review this PR?

Copy link
Collaborator

@DavidHuber-NOAA DavidHuber-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed the new spack-stack location is correct. Thanks!

@DavidHuber-NOAA
Copy link
Collaborator

@RussTreadon-NOAA @ShunLiu-NOAA Can we go ahead and merge this unless there are any more approvals needed?

@RussTreadon-NOAA
Copy link
Contributor

@ShunLiu-NOAA asked Ming, Cory, and I if ctests need to be run for the PR on WCOSS2, hera, orion, or hercules. We agreed that confirmation that the changes work on Jet is sufficient.

@ShunLiu-NOAA ShunLiu-NOAA merged commit 8e279f9 into NOAA-EMC:develop Apr 25, 2024
4 checks passed
@ShunLiu-NOAA
Copy link
Contributor

I should merge this yesterday after approval from Russ, Cory and Ming.

@InnocentSouopgui-NOAA InnocentSouopgui-NOAA deleted the migration/jet-rocky8 branch August 28, 2024 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate to Rocky8 spack-stack on Jet
5 participants