Update fix files to include the *_CLDDET.NL files for CADS

[wx20jjung]

Description
The new infrared cloud and aerosol detection software has several tunable parameters that will be specific to different instruments (AIRS, CrIS, IASI). These files are read by the GSI and used for the specific instrument. These files are the cloud detection parameters derived for the specific instruments.

Fixes #739

Type of change

• New feature (non-breaking change which adds functionality)

How Has This Been Tested?
I have been testing and tuning these *_CLDDET.NL files within a recent version of the global-workflow on Hera. For this specific PR, I pointed the FIXgsi variable within the global workflow to the fix directory within this branch. Bit identical cost functions were produced. Both gdasanal tests set CRIS_CADS=.true. and IASI_CADS=.true. which uses the *_CLDDET.NL files. The current ctests do not use these new files.

control:
FIXgsi=/scratch1/NCEPDEV/jcsda/Jim.Jung/noscrub/global-workflow/fix/gsi
cost,grad,step,b,step? = 1 0 1.572082981537153479E+06 5.162285845468648404E+03 8.603064812549240381E-01 0.000000000000000000E+00 good
cost,grad,step,b,step? = 2 150 1.163641044648056850E+06 8.899223101760822985E+00 1.077442122849054051E+00 8.917117178616245088E-01 good

new gsi branch
FIXgsi=/scratch1/NCEPDEV/jcsda/Jim.Jung/noscrub/GSI_CADS-fix/fix
cost,grad,step,b,step? = 1 0 1.572082981537153479E+06 5.162285845468648404E+03 8.603064812549240381E-01 0.000000000000000000E+00 good
cost,grad,step,b,step? = 2 150 1.163641044648056850E+06 8.899223101760822985E+00 1.077442122849054051E+00 8.917117178616245088E-01 good

Checklist

• My code follows the style guidelines of this project
• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• New and existing tests pass with my changes
• Any dependent changes have been merged and published

[RussTreadon-NOAA]

@wx20jjung , who would you like assigned as peer reviewers?

[DavidHuber-NOAA]

The change looks good. Approve.

I would like to request an update to the ctests (or perhaps a new ctest) that tests this capability. That could be handled in a separate Issue/PR.

[RussTreadon-NOAA]

@ADCollard and @DavidHuber-NOAA - please pause your review of this PR. @wx20jjung has two more changes for this PR

1. update OBSQC in the global_4denvar section of regression/regression_namelists.sh
2. add links to the three new fix files in regression/global_4denvar.sh

[RussTreadon-NOAA]

Thank you @DavidHuber-NOAA for your quick review. @wx20jjung is updating the global_4denvar ctest to use the new fix files. It's not clear at present if regional DA will use the CADS scheme in future operational implementations.

[RussTreadon-NOAA]

Changes look good. Approve pending successful ctests.

[wx20jjung]

My crests on Hera all pass. ***@***.*** build]$ ctest -j 7 Test project /scratch1/NCEPDEV/jcsda/Jim.Jung/save/ctests/update/build Start 1: global_4denvar Start 2: rtma Start 3: rrfs_3denvar_glbens Start 4: netcdf_fv3_regional Start 5: hafs_4denvar_glbens Start 6: hafs_3denvar_hybens Start 7: global_enkf 1/7 Test #4: netcdf_fv3_regional .............. Passed 1868.79 sec 2/7 Test #3: rrfs_3denvar_glbens .............. Passed 1872.84 sec 3/7 Test #2: rtma ............................. Passed 1989.32 sec 4/7 Test #6: hafs_3denvar_hybens .............. Passed 2004.73 sec 5/7 Test #5: hafs_4denvar_glbens .............. Passed 2063.50 sec 6/7 Test #1: global_4denvar ................... Passed 2206.17 sec 7/7 Test #7: global_enkf ...................... Passed 2330.99 sec 100% tests passed, 0 tests failed out of 7 I checked the various stdout files and the *_CADS flags are set as expected, CrIS and IASI are true for the global_4denvar, all others are false. The *_CLDDET.NL files are are also copied into the global_4denvar working directories and are missing in all of the others, as expected.

…

On Mon, Apr 29, 2024 at 10:43 AM RussTreadon-NOAA ***@***.***> wrote: ***@***.**** approved this pull request. Changes look good. Approve pending successful ctests. — Reply to this email directly, view it on GitHub <#740 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AMPASA6EJB64EOTTLS3HWFTY7ZMBVAVCNFSM6AAAAABGZ44TJKVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDAMRYG4ZDANJZGQ> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[RussTreadon-NOAA]

WCOSS2 test
wx20jjung:CADS-fix installed on Cactus. ctests run with the following results

Test project /lfs/h2/emc/da/noscrub/russ.treadon/git/gsi/pr740/build
    Start 1: global_4denvar
    Start 2: rtma
    Start 3: rrfs_3denvar_glbens
    Start 4: netcdf_fv3_regional
    Start 5: hafs_4denvar_glbens
    Start 6: hafs_3denvar_hybens
    Start 7: global_enkf
1/7 Test #4: netcdf_fv3_regional ..............   Passed  483.04 sec
2/7 Test #3: rrfs_3denvar_glbens ..............   Passed  485.94 sec
3/7 Test #7: global_enkf ......................   Passed  849.81 sec
4/7 Test #2: rtma .............................   Passed  968.28 sec
5/7 Test #5: hafs_4denvar_glbens ..............   Passed  1213.31 sec
6/7 Test #6: hafs_3denvar_hybens ..............   Passed  1214.17 sec
7/7 Test #1: global_4denvar ...................   Passed  1682.67 sec

100% tests passed, 0 tests failed out of 7

Total Test time (real) = 1682.72 sec

Check global_4denvar run directory. CRIS_CLDDET.NL and IASI_CLDDET.NL files present. OBSQC namelist includes cris_cads=.true.,iasi_cads=.true.

[RussTreadon-NOAA]

@DavidHuber-NOAA and @ADCollard : all changes for this PR have been committed to wx20jjung:CADS-fix. Hera and WCOSS2 (Cactus) ctests confirm expected behavior.

[DavidHuber-NOAA]

@wx20jjung Thank you for adding CADS to the global_4denvar test case. The changes look good and the expected behavior is noted. Approve.

[ADCollard]

Looks good.