Move to contrib spack-stack on Jet #787
Conversation
|
@KateFriedman-NOAA and @DavidHuber-NOAA , if you have time would both review this PR? This PR is in support of g-w issue #2841. GSI PRs need approval from two peer reviewers. Tagging @hu5970 and @ShunLiu-NOAA for awareness since I believe regional DA uses Jet. |
There was a problem hiding this comment.
The spack-stack path is correct. @InnocentSouopgui-NOAA Have you been able to run the regression tests on Jet?
No, I have not run the regression test. So my plan is to run a couple of cycled experiment with global workflow, at different resolutions available on Jet. What do you think @DavidHuber-NOAA ? |
|
@InnocentSouopgui-NOAA You can let the control be the same version by cloning it into git clone git@github.com:InnocentSouopgui-NOAA/gsi -b migration-jet-contrib develop
cd develop/
./ush/build.sh
module use modulefiles
module load gsi_jet.intel
cd build
cmake ..
make
make install
cd regression
ctest -j 7 |
|
@InnocentSouopgui-NOAA , you don't need a control. You could do the following on Jet
|
|
I tried to run the regression test. This is the first time I am running the GIS's regression tests. |
|
@InnocentSouopgui-NOAA May I take a look at your local clone? |
|
Yes @DavidHuber-NOAA , |
|
@InnocentSouopgui-NOAA , do the following
You should see 6 tests listed |
|
Ah, I see the issue. For context, the regression test works by running the GSI cases twice. Once for the directory you are running from and once for the "develop" branch. The RTs assume that the develop branch is named "develop" locally. So you can trick it by naming the branch that you are running from "develop" and it will run the same version twice. |
|
As a test, I did what I suggested above but copied to |
|
Jet ctests The The timing threshold test is not robust. This failure is not a fatal failure. A rerun of this test could return Passed. |
|
Jet ctest follow-up Account Test From the job log file we see |
|
@RussTreadon-NOAA I had to delete the old |
|
@DavidHuber-NOAA , I'm still seeing failures when Directory |
|
@RussTreadon-NOAA My apologies. I have modified my rsync command to follow symlinks. The data should all be available now. |
|
@DavidHuber-NOAA , thank you. The |
|
Can we separate this PR from the issue on Ctests, in order to move forward with Global Workflow PR. |
|
@InnocentSouopgui-NOAA , we can do as you suggest, but we need to do the following first
|
|
Finally got Jet GSI ctests times are extremely high. My account can only use the This PR can be merged pending approval from two peer reviews. Note: My approval does not count as a peer reviewer. |
|
@InnocentSouopgui-NOAA , were you ever able to run the GSI ctests on Jet? If so, please post the results in this PR. |
These actions are no longer necessary. I was able to run ctests on Jet. It would be good to get confirmation from other developers that they, too, can run ctests on Jet. |
|
I will try running the ctests on Jet this morning. |
|
Thank you @DavidHuber-NOAA but do not stop other work just to run GSI ctests on Jet. @InnocentSouopgui-NOAA said |
|
Thank you @DavidHuber-NOAA! |
* origin/develop: Move to contrib spack-stack on Jet (NOAA-EMC#787) a quick workaround for increasing the mpi task numbers on orion for ctest :: rrfs_3denvar_rdasens (NOAA-EMC#788) Recover the capability of handling model fields from operation gfs.v16.3 (NOAA-EMC#785) fix a bug in deter_sfc_gmi (NOAA-EMC#781) add safeguard to thompson_reff (NOAA-EMC#779) Fix incorrect usage of real(i_kind) in mg_input.f90 (NOAA-EMC#760) Transition to Thompson Microphysics for Microwave All-sky Assimilation (NOAA-EMC#743) Format changes for EUMETSAT metop-sg and CADS debug fix (NOAA-EMC#773) Update global_4denvar and global_enkf ctests to reflect GFS v17 (NOAA-EMC#774) fix for cris-fsr memory corruption (NOAA-EMC#767) Gnssrwnd1.0 (NOAA-EMC#747)
Description
Following the failure of the lfs4 storage, spack stack was moved to /contrib and jet module files needs updates.
This PR updates Jet module files to point to the new path of spack stack.
Fixes #786
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Checklist