Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix for mom6solo to be built #43

Merged
merged 1 commit into from
Nov 25, 2020
Merged

Bugfix for mom6solo to be built #43

merged 1 commit into from
Nov 25, 2020

Conversation

aerorahul
Copy link

This PR:

Currently, when dev/emc is checked out and used to build the mom6 solo executable, it encounters errors as documented in #41

A patch is provided in this PR.

This should not be treated as a final solution.
A proper solution should be reached with GFDL so that the following files are not diverging from main

src/core/MOM_forcing_type.F90
src/user/MOM_wave_interface.F90

@jiandewang
Copy link
Collaborator

@aerorahul agree with your opinion

@jiandewang
Copy link
Collaborator

@aerorahul can you modify your commit log to include information like "make the last argument in subroutine Update_Surface_Waves to be optional in MOM_wave_interface.F90"

…be optional in src/user/MOM_wave_interface.F90. This is a bug from PR #23 bbdef39.
@aerorahul
Copy link
Author

aerorahul commented Nov 24, 2020

@aerorahul can you modify your commit log to include information like "make the last argument in subroutine Update_Surface_Waves to be optional in MOM_wave_interface.F90"

@jiandewang done

@jiandewang jiandewang merged commit 18bf388 into dev/emc Nov 25, 2020
@aerorahul aerorahul deleted the bugfix/mom6solo-ufs branch April 26, 2021 20:06
jiandewang pushed a commit to jiandewang/MOM6 that referenced this pull request Jun 17, 2021
Merge in latest dev/gfdl updates
jiandewang pushed a commit to jiandewang/MOM6 that referenced this pull request Feb 1, 2022
+(*)Rescale opacity and avoid segmentation faults
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix MOM6SOLO build in the EMC branch.
2 participants