added g2c_ versions of png and openjpeg enc/dec functions #545
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlysonStahl-NOAA
requested review from
edwardhartnett and
DusanJovic-NOAA
and removed request for
edwardhartnett
edwardhartnett
approved these changes
Nov 1, 2024
DusanJovic-NOAA
approved these changes
Nov 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
wgrib2 now uses g2c_enc_jpeg2000() / g2c_dec_jpeg2000() for Jasper only (see recent PR). I'm adding these functions so wgrib2 can use g2c decode functions for OpenJPEG and PNG as well.
It wouldn't be difficult to just make these changes in wgrib2 and convert the int inputs to g2int, however, seeing how these functions already existed for Jasper, it made more sense to me to add the functions here.